Skip to content

fix: Add credential auth and test for Twilio, Pipedrive, Asana, Freshdesk, Workable#28265

Merged
BerniWittmann merged 5 commits intomasterfrom
node-4814-batch-1-credential-authtest-updates-twilio-pipedrive-asana
Apr 23, 2026
Merged

fix: Add credential auth and test for Twilio, Pipedrive, Asana, Freshdesk, Workable#28265
BerniWittmann merged 5 commits intomasterfrom
node-4814-batch-1-credential-authtest-updates-twilio-pipedrive-asana

Conversation

@BerniWittmann
Copy link
Copy Markdown
Member

@BerniWittmann BerniWittmann commented Apr 9, 2026

Summary

Add missing authenticate and/or test properties to 5 credential files as part of the ongoing credential auth/test updates (NODE-2621).

Credential Linear Issue Auth Method Test Endpoint Needs
Twilio API NODE-2740 HTTP Basic Auth (AccountSID:AuthToken) GET /2010-04-01/Accounts/{accountSid}.json test only
Pipedrive API NODE-2795 Query string api_token GET /v1/userSettings test only
Asana API NODE-2817 Bearer token header GET /api/1.0/users/me test only
Freshdesk API NODE-2706 HTTP Basic Auth (apiKey:X) GET /api/v2/agents/me authenticate + test
Workable API NODE-2810 Bearer token header GET /spi/v3/jobs authenticate + test

All auth patterns verified against both GenericFunctions and current API documentation.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-4814
https://linear.app/n8n/issue/NODE-2621

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

@BerniWittmann BerniWittmann marked this pull request as ready for review April 9, 2026 15:44
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Architecture diagram
sequenceDiagram
    participant UI as n8n UI
    participant Core as n8n Server (Core)
    participant Cred as Credential Definition
    participant API as External API (e.g., Twilio, Asana)

    Note over UI,API: Credential Validation Flow (Test Connection)

    UI->>Core: POST /credentials/test
    Core->>Cred: Load credential definition

    Note over Core,Cred: PR adds 'test' and 'authenticate' logic

    Core->>Core: Resolve credentials (e.g., apiKey, domain)
    Core->>Core: NEW: Parse test.request (URL/baseURL)
    
    alt NEW: 'authenticate' property defined (Freshdesk/Workable)
        Core->>Core: Map credentials to Request (Headers/Basic Auth)
    else Standard/Query Auth (Pipedrive/Asana/Twilio)
        Core->>Core: Use existing auth mapping logic
    end

    Core->>API: NEW: GET request to test endpoint
    Note right of API: e.g., /users/me, /agents/me, or /jobs

    alt API Success
        API-->>Core: 200 OK
        Core-->>UI: Connection successful
    else API Failure
        API-->>Core: 401 Unauthorized / 404 Not Found
        Core-->>UI: Connection failed
    end

    Note over UI,API: Runtime Execution Flow (Node Usage)

    opt If 'authenticate' changed (Freshdesk/Workable)
        Core->>Core: NEW: Automatically inject auth headers into node requests
    end
Loading

@Joffcom Joffcom requested a review from alexander-gekov April 10, 2026 06:06
@n8n-assistant n8n-assistant Bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 10, 2026
Copy link
Copy Markdown
Member

@alexander-gekov alexander-gekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait, pulled the changes and everything seems to be good!

@BerniWittmann BerniWittmann added this pull request to the merge queue Apr 23, 2026
Merged via the queue into master with commit a2aa69d Apr 23, 2026
95 of 97 checks passed
@BerniWittmann BerniWittmann deleted the node-4814-batch-1-credential-authtest-updates-twilio-pipedrive-asana branch April 23, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team node/improvement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants