fix: Add credential auth and test for Twilio, Pipedrive, Asana, Freshdesk, Workable#28265
Merged
BerniWittmann merged 5 commits intomasterfrom Apr 23, 2026
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
No issues found across 5 files
Architecture diagram
sequenceDiagram
participant UI as n8n UI
participant Core as n8n Server (Core)
participant Cred as Credential Definition
participant API as External API (e.g., Twilio, Asana)
Note over UI,API: Credential Validation Flow (Test Connection)
UI->>Core: POST /credentials/test
Core->>Cred: Load credential definition
Note over Core,Cred: PR adds 'test' and 'authenticate' logic
Core->>Core: Resolve credentials (e.g., apiKey, domain)
Core->>Core: NEW: Parse test.request (URL/baseURL)
alt NEW: 'authenticate' property defined (Freshdesk/Workable)
Core->>Core: Map credentials to Request (Headers/Basic Auth)
else Standard/Query Auth (Pipedrive/Asana/Twilio)
Core->>Core: Use existing auth mapping logic
end
Core->>API: NEW: GET request to test endpoint
Note right of API: e.g., /users/me, /agents/me, or /jobs
alt API Success
API-->>Core: 200 OK
Core-->>UI: Connection successful
else API Failure
API-->>Core: 401 Unauthorized / 404 Not Found
Core-->>UI: Connection failed
end
Note over UI,API: Runtime Execution Flow (Node Usage)
opt If 'authenticate' changed (Freshdesk/Workable)
Core->>Core: NEW: Automatically inject auth headers into node requests
end
alexander-gekov
approved these changes
Apr 23, 2026
Member
alexander-gekov
left a comment
There was a problem hiding this comment.
Sorry for the long wait, pulled the changes and everything seems to be good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
authenticateand/ortestproperties to 5 credential files as part of the ongoing credential auth/test updates (NODE-2621).GET /2010-04-01/Accounts/{accountSid}.jsontestonlyapi_tokenGET /v1/userSettingstestonlyGET /api/1.0/users/metestonlyGET /api/v2/agents/meauthenticate+testGET /spi/v3/jobsauthenticate+testAll auth patterns verified against both GenericFunctions and current API documentation.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-4814
https://linear.app/n8n/issue/NODE-2621
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)