Skip to content

Rename run_with_extra_handlers to run_with_handlers#56

Merged
congwang-mk merged 1 commit into
mainfrom
rename-run-with-handlers
May 25, 2026
Merged

Rename run_with_extra_handlers to run_with_handlers#56
congwang-mk merged 1 commit into
mainfrom
rename-run-with-handlers

Conversation

@congwang-mk
Copy link
Copy Markdown
Contributor

Aligns the Rust core method names with the FFI and Python API, where the sandlock_run_with_handlers C ABI symbol and Sandbox.run_with_handlers never carried extra.

Renames run_with_extra_handlers / run_interactive_with_extra_handlers (and the internal helper, field, params, tests, and docs). No behavior or ABI change. Rust (561) and Python (321) suites pass.

🤖 Generated with Claude Code

Signed-off-by: Cong Wang <cwang@multikernel.io>
@congwang-mk
Copy link
Copy Markdown
Contributor Author

@dzerik Please take a look. Thanks.

Copy link
Copy Markdown
Contributor

@dzerik dzerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Clean rename, no blockers. Verified locally against head sha 41d31a4:

  • Instrumental grep: for all seven renamed identifiers (run_with_extra_handlers, run_interactive_with_extra_handlers, sandbox_collect_extra_handlers, extra_handlers, extra_handler_tests, test_extra_handlers, ExtraHandler) returns zero matches across crates/, docs/, README.md.
  • Build clean: cargo build --release succeeds on the workspace (sandlock-core, sandlock-ffi, sandlock-cli).
  • Library tests pass: cargo test --release --lib -p sandlock-core — 275 passed, 0 failed.
  • crates/sandlock-ffi/src/handler/run.rs:124-126 correctly call run_interactive_with_handlers / run_with_handlers.
  • Doc-comments in dispatch.rs (intra-doc links) and docs/extension-handlers.md are consistent with the new names.
  • Trait Handler was already the name; no breaking surface for downstream impl ExtraHandler callers.
  • Naming aligns with the C ABI (sandlock_run_with_handlers) and the Python wrapper (Sandbox.run_with_handlers) as the PR description states.

@congwang-mk congwang-mk merged commit 63240cb into main May 25, 2026
8 checks passed
@congwang-mk congwang-mk deleted the rename-run-with-handlers branch May 25, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants