Rename run_with_extra_handlers to run_with_handlers#56
Merged
Conversation
Signed-off-by: Cong Wang <cwang@multikernel.io>
Contributor
Author
|
@dzerik Please take a look. Thanks. |
dzerik
reviewed
May 25, 2026
Contributor
dzerik
left a comment
There was a problem hiding this comment.
Code review
Clean rename, no blockers. Verified locally against head sha 41d31a4:
- Instrumental grep: for all seven renamed identifiers (
run_with_extra_handlers,run_interactive_with_extra_handlers,sandbox_collect_extra_handlers,extra_handlers,extra_handler_tests,test_extra_handlers,ExtraHandler) returns zero matches acrosscrates/,docs/,README.md. - Build clean:
cargo build --releasesucceeds on the workspace (sandlock-core, sandlock-ffi, sandlock-cli). - Library tests pass:
cargo test --release --lib -p sandlock-core— 275 passed, 0 failed. crates/sandlock-ffi/src/handler/run.rs:124-126correctly callrun_interactive_with_handlers/run_with_handlers.- Doc-comments in
dispatch.rs(intra-doc links) anddocs/extension-handlers.mdare consistent with the new names. - Trait
Handlerwas already the name; no breaking surface for downstreamimpl ExtraHandlercallers. - Naming aligns with the C ABI (
sandlock_run_with_handlers) and the Python wrapper (Sandbox.run_with_handlers) as the PR description states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the Rust core method names with the FFI and Python API, where the
sandlock_run_with_handlersC ABI symbol andSandbox.run_with_handlersnever carriedextra.Renames
run_with_extra_handlers/run_interactive_with_extra_handlers(and the internal helper, field, params, tests, and docs). No behavior or ABI change. Rust (561) and Python (321) suites pass.🤖 Generated with Claude Code