This repository was archived by the owner on Sep 2, 2025. It is now read-only.
Fix ros.isolateEnvironment type#1305
Merged
ooeygui merged 2 commits intoms-iot:masterfrom May 30, 2025
dackjavidson:fix-isolate-env-type
Merged
Fix ros.isolateEnvironment type#1305ooeygui merged 2 commits intoms-iot:masterfrom dackjavidson:fix-isolate-env-type
ooeygui merged 2 commits intoms-iot:masterfrom
dackjavidson:fix-isolate-env-type
Conversation
Author
@microsoft-github-policy-service agree |
ooeygui
approved these changes
May 30, 2025
Member
ooeygui
left a comment
There was a problem hiding this comment.
Great Catch! Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
package.jsonto use the proper JSON type name for a boolean: "bool" -> "boolean". This fixes a minor bug wheredevcontainer.jsoncomplains about the input value no matter what you put, because it can't return a "bool", only a "boolean".Before:

After:
