Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

Fix ros.isolateEnvironment type#1305

Merged
ooeygui merged 2 commits intoms-iot:masterfrom
dackjavidson:fix-isolate-env-type
May 30, 2025
Merged

Fix ros.isolateEnvironment type#1305
ooeygui merged 2 commits intoms-iot:masterfrom
dackjavidson:fix-isolate-env-type

Conversation

@dackjavidson
Copy link
Copy Markdown

Update package.json to use the proper JSON type name for a boolean: "bool" -> "boolean". This fixes a minor bug where devcontainer.json complains about the input value no matter what you put, because it can't return a "bool", only a "boolean".

Before:
Screenshot from 2025-05-29 15-12-07

After:
Screenshot from 2025-05-29 15-44-09

@dackjavidson dackjavidson requested a review from a team as a code owner May 29, 2025 23:05
@dackjavidson
Copy link
Copy Markdown
Author

@dackjavidson please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

@ooeygui ooeygui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Catch! Thank you for the contribution!

@ooeygui ooeygui merged commit b216c0d into ms-iot:master May 30, 2025
5 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants