Updated the moqui.server.Visit relationship type from one to one-nofk to remove the foreign key constraint on the Visit entity.#653
Open
dixitdeepak wants to merge 1 commit into
Conversation
…t blocking visit data purging.
moqui.server.Visit relationship type from one to one-nofk to remove the foreign key constraint on the Visit entity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
onerelationship type generates a database-level foreign key (FK) constraint, which causes issues during visit data purging. When visit/visitor records are purged, the FK constraint prevents deletion of related records, leading to constraint violations.This aligns with the existing pattern used in
ArtifactHit, which already usesone-nofkfor its Visit relationship — reinforcing that FK constraints are not appropriate for transient session/visit data.ArtifactHithandles the same relationship