Skip to content

Add "--tls-generate" flag to examples#1959

Open
thomshutt-fastly wants to merge 1 commit into
moq-dev:mainfrom
thomshutt-fastly:patch-1
Open

Add "--tls-generate" flag to examples#1959
thomshutt-fastly wants to merge 1 commit into
moq-dev:mainfrom
thomshutt-fastly:patch-1

Conversation

@thomshutt-fastly

Copy link
Copy Markdown

Running without these throws the error:

Error: must provide at least one cert/key pair or generate entry

Running without these throws the error:

Error: must provide at least one cert/key pair or generate entry

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @thomshutt-fastly, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 409dccfd-1b52-42d2-a51a-06b2495b8972

📥 Commits

Reviewing files that changed from the base of the PR and between 7c6d4dd and 0dca718.

📒 Files selected for processing (1)
  • rs/moq-cli/README.md

Walkthrough

The Self-host section in rs/moq-cli/README.md was updated to add --tls-generate "localhost" to both the serve and accept command examples. The accept example retains --format fmp4 and the pipe to ffplay -.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding the --tls-generate flag to README examples.
Description check ✅ Passed The description is directly related to the change by explaining why the examples now include --tls-generate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant