fix(smoke): update interop clients to the current dev APIs#1952
Merged
Conversation
The smoke clients had drifted against dev's networking/catalog APIs and were
failing before the main->dev merge:
- c: moq_origin_consume was renamed; use the async moq_origin_consume_announced
with an on_broadcast callback that wakes main once the broadcast is announced.
- python: subscribe_catalog() is now a coroutine returning a CatalogConsumer;
await it before iterating.
- js-native: Catalog.fetch was removed; reconstruct the catalog via
Json.Consumer (new @moq/json dep). Frame is now {data, timestamp}, so read
frame.data.byteLength.
- js (browser driver): video stats moved to backend.video.output.stats;
decoding was fine, the driver just read the wrong path and saw 0 frames.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cross-language smoke clients had drifted against dev's networking/catalog APIs and were failing before the main→dev merge (#1950). This fixes each client against the current dev surface.
implicit declaration of moq_origin_consume(renamed)moq_origin_consume_announced+ anon_broadcastcallback that wakesmainonce the broadcast is announced (replaces the old synchronous poll loop).'async for' requires __aiter__, got coroutinesubscribe_catalog()is now a coroutine returning aCatalogConsumer;awaitit before iterating.Catalog.fetch is not a functionJson.Consumer(new@moq/jsondep).Frameis now{data, timestamp}, so readframe.data.byteLength(would have failed next otherwise).decoded 0 framesbackend.video.statstobackend.video.output.stats. Decoding was actually fine; the Playwright driver just polled the wrong path and always read 0.Test plan
-Werror=implicit-function-declarationagainst the freshly generatedmoq.h; call signature matchesmoq_origin_consume_announced.tsc --noEmitclean;@moq/jsonlinked viabun install.ruff checkclean; confirmed the downstreamsubscribe_media/frame.payload/video.containersurface still matchesmoq-ffi.bun.lockupdated for the new workspace dep.just test smoke-fullin CI (the point of the PR).(Written by Claude)