refactor(dev-server-legacy): migrate tests to node:test#3083
Open
bennypowers wants to merge 2 commits into
Open
refactor(dev-server-legacy): migrate tests to node:test#3083bennypowers wants to merge 2 commits into
bennypowers wants to merge 2 commits into
Conversation
Replace mocha globals and chai assertions with node:test and
node:assert/strict. First TypeScript test migration in the series.
- `import { expect } from 'chai'` -> `import assert from 'node:assert/strict'`
- Add `import { describe, it } from 'node:test'`
- `expect(x).to.equal(y)` -> `assert.equal(x, y)`
- `this.timeout(10000)` -> `{ timeout: 10000 }` option on describe
- `__dirname` -> `import.meta.dirname`
- `../src/legacyPlugin.js` -> `../dist/legacyPlugin.js`
- `./userAgents.js` -> `./userAgents.ts`
- Add `--test-force-exit` to prevent test hangs from open handles
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
CI sets NODE_OPTIONS='--no-experimental-strip-types' to support un-migrated mocha+ts-node packages. The CLI flag overrides NODE_OPTIONS, letting migrated .ts test files run with native type stripping. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@web/dev-server-legacytests from mocha/chai tonode:test+node:assert/strictdist/(compiled output)__dirnamereplaced withimport.meta.dirname.jsimport paths updated to.tsTest plan