Skip to content

fix(installer): replace in-use DLL on reboot (upgrade DeleteFile error 5)#41

Merged
mkpoli merged 1 commit into
masterfrom
fix/installer-locked-dll
Jun 27, 2026
Merged

fix(installer): replace in-use DLL on reboot (upgrade DeleteFile error 5)#41
mkpoli merged 1 commit into
masterfrom
fix/installer-locked-dll

Conversation

@mkpoli

@mkpoli mkpoli commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Fixes the upgrade install failure reported with a screenshot: replacing C:\Program Files\ainuKey\ainukey.dll fails with DeleteFile error code 5 (access denied) because the old DLL is loaded by Windows text services (registered TSF IME). The error dialog also offers "Skip this file", which for the core DLL would leave a broken install.

Adds restartreplace uninsrestartdelete to the DLL [Files] entry: when the DLL is in use, Setup schedules the replacement for the next reboot instead of erroring (no skip prompt). First-time installs (nothing loaded) replace normally, no reboot. Version → 0.3.4.

Immediate workaround for anyone already stuck: Cancel → uninstall old ainuKey → sign out/in → reinstall.

On an upgrade the old ainukey.dll is loaded by Windows text services, so Setup
can't delete it — users hit 'DeleteFile error, code 5 / access denied' with a
retry/skip/cancel prompt, and skipping the core DLL leaves a broken install.

Add restartreplace + uninsrestartdelete to the DLL [Files] entry: a locked DLL is
scheduled for replacement on the next reboot (no error, no skip); first-time
installs (nothing loaded) replace normally with no reboot. Bumps to 0.3.4.
@mkpoli mkpoli merged commit bf25ae0 into master Jun 27, 2026
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mkpoli, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 33 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 692f6fe1-6a27-4c91-86b9-f22d4f2b9f6d

📥 Commits

Reviewing files that changed from the base of the PR and between 55017b2 and a7b0ec7.

📒 Files selected for processing (2)
  • Cargo.toml
  • installer/ainuKey.iss
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/installer-locked-dll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant