feat(version): stamp the binaries so the build is identifiable#39
Merged
Conversation
Until now nothing reported a version: Cargo.toml said 0.2.1, the DLL had no VERSIONINFO, and the settings dialog showed no version — so there was no way to confirm which build was installed. - Cargo.toml bumped to 0.3.3 (single source of truth). - build.rs embeds a Windows VERSIONINFO resource in ainukey.dll from CARGO_PKG_VERSION, so Explorer → Properties → Details shows File/Product version (validated with llvm-rc). Same no-op-on-non-MSVC path as the icon embed. - settings dialog title now reads 'ainuKey vX.Y.Z — 設定 / Settings'. - installer .iss sets VersionInfoVersion so setup.exe carries the version too. All three (DLL, installer, dialog) derive from the version, so they agree when Cargo.toml is bumped with the release tag.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR bumps the crate version and propagates that version into the generated Windows resource, installer metadata, and settings dialog title. ChangesVersion stamping
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "no way to confirm the version of each binary." Nothing reported a version:
Cargo.tomlsaid0.2.1, the DLL had no VERSIONINFO, and the settings dialog showed no version.build.rsgenerates + embeds a version resource fromCARGO_PKG_VERSION, so Explorer → Properties → Details shows File/Product version. Validated locally withllvm-rc(compiles to a valid.reswith the version strings). Same non-MSVC no-op path as the existing icon embed.ainuKey vX.Y.Z — 設定 / Settings, so opening Settings confirms the running build..isssetsVersionInfoVersion, sosetup.execarries the version in its Properties.All three derive from the version and agree when Cargo.toml is bumped with the tag. Clippy
-D warningsclean; cross-link green.Goes into v0.3.3 alongside the already-merged Start-menu settings fix (#31).
Summary by CodeRabbit
New Features
Chores