fix: [hotfix] await background load futures during cancellation and fix loadingTimeoutMs default#48881
Closed
sparknack wants to merge 3 commits intomilvus-io:hotfix-2.6.14from
Closed
fix: [hotfix] await background load futures during cancellation and fix loadingTimeoutMs default#48881sparknack wants to merge 3 commits intomilvus-io:hotfix-2.6.14from
sparknack wants to merge 3 commits intomilvus-io:hotfix-2.6.14from
Conversation
…nslators Ensure background load futures are properly awaited during cancellation cleanup in both GroupChunkTranslator and ManifestGroupTranslator to prevent dangling async operations. Also add CheckCancellation calls in LoadCellBatchAsync to support early termination during cell loading. Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
sparknack
changed the title
Contributor
|
@sparknack Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #") |
mergify
Bot
added
do-not-merge/missing-related-pr
kind/bug
sre-ci-robot
added
do-not-merge/need-merge-master-first
Contributor
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## hotfix-2.6.14 #48881 +/- ##
=================================================
- Coverage 82.48% 82.47% -0.01%
=================================================
Files 555 555
Lines 88075 88118 +43
=================================================
+ Hits 72646 72674 +28
- Misses 15377 15392 +15
Partials 52 52
🚀 New features to boost your workflow:
|
sre-ci-robot
added
the
low-code-coverage
Contributor
zhengbuqian
approved these changes
Apr 13, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sparknack, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
Contributor
|
/lgtm |
Contributor
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
Contributor
Author
|
/retest |
2 tasks
Contributor
Author
|
Superseded by #48990 (re-submitted against hotfix-2.6.14 to trigger fresh CI). |
sre-ci-robot
pushed a commit
that referenced
this pull request
Apr 14, 2026
…n and fix loadingTimeoutMs default (#48990) ## Summary Re-submission of #48881 to trigger fresh CI against `hotfix-2.6.14` base. Content unchanged. - Await background load futures in `GroupChunkTranslator` and `ManifestGroupTranslator` cancellation cleanup paths to prevent use-after-free / dangling futures - Add `CheckCancellation` calls in `LoadCellBatchAsync` loop for prompt cancellation - Fix `tieredStorage.loadingTimeoutMs` default from `0` (immediate failure) to `-1` (no timeout) issue: #48854 pr: #48880 ## Test plan - [x] Added unit test `CancellationStopsMidBatchPush` verifying mid-batch cancellation stops loading and raises `FollyCancel` - [ ] CI passes --------- Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupChunkTranslatorandManifestGroupTranslatorcancellation cleanup paths to prevent use-after-free / dangling futuresCheckCancellationcalls inLoadCellBatchAsyncloop for prompt cancellationtieredStorage.loadingTimeoutMsdefault from0(immediate failure) to-1(no timeout)issue: #48854
Test plan
CancellationStopsMidBatchPushverifying mid-batch cancellation stops loading and raisesFollyCancel