test: [cp3.0] update default_nb from 2000 to 3000 across all test modules#48877
Merged
sre-ci-robot merged 1 commit intomilvus-io:3.0from Apr 11, 2026
Merged
test: [cp3.0] update default_nb from 2000 to 3000 across all test modules#48877sre-ci-robot merged 1 commit intomilvus-io:3.0from
sre-ci-robot merged 1 commit intomilvus-io:3.0from
Conversation
…lvus-io#48787) - Update `default_nb` from 2000 to 3000 across Python client, RESTful v2, and index test modules - Index creation requires > 2048 rows, so the previous default of 2000 was insufficient - Replace hardcoded `nb=2000` with `ct.default_nb` references for better maintainability - Add `default_nb` constant to RESTful v2 and replace hardcoded `nb=100`/`nb=200` with `nb=3000` | Module | Change | |--------|--------| | `python_client/common/common_type.py` | `default_nb = 2000` → `3000` | | `python_client/testcases/indexes/*` | 7 files: local `default_nb = 2000` → `ct.default_nb` | | `python_client/milvus_client/*` | 5 files: hardcoded `nb=2000` → `ct.default_nb` | | `python_client/milvus_client_v2/*` | 6 files: hardcoded `nb=2000` → `ct.default_nb` | | `python_client/testcases/*` | 3 files: hardcoded `nb=2000` → `ct.default_nb` | | `restful_client_v2/utils/constant.py` | Added `default_nb = 3000` | | `restful_client_v2/base/testbase.py` | `init_collection` default `nb=100` → `nb=3000` | | `restful_client_v2/utils/utils.py` | `get_data_by_payload` default `nb=100` → `nb=3000` | | `restful_client_v2/testcases/*` | 4 files: hardcoded `nb=100`/`nb=200` → `nb=3000` | issue: milvus-io#42446 --------- Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit 0a689a7)
Contributor
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
Contributor
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yanliang567, zhuwenxing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #48787 to 3.0 branch.
default_nbfrom 2000 to 3000 across Python client, RESTful v2, and index test modulesnb=2000/nb=100/nb=200/nb=3000withct.default_nb/default_nbreferences for better maintainabilityCherry-pick conflict resolution
tests/python_client/testcases/test_large_topk.pywas deleted in 3.0, so its changes were skipped.tests/python_client/milvus_client_v2/test_milvus_client_search_none_default.pyhad a structural conflict (3.0 usescollection_w.searchinstead ofself.search); only the targetednb = 2000→nb = ct.default_nbchange at the relevant test method was applied.pr: #48787