test: [cp2.6] update default_nb from 2000 to 3000 across all test modules#48876
Merged
sre-ci-robot merged 8 commits intomilvus-io:2.6from Apr 16, 2026
Merged
test: [cp2.6] update default_nb from 2000 to 3000 across all test modules#48876sre-ci-robot merged 8 commits intomilvus-io:2.6from
sre-ci-robot merged 8 commits intomilvus-io:2.6from
Conversation
…lvus-io#48787) - Update `default_nb` from 2000 to 3000 across Python client, RESTful v2, and index test modules - Index creation requires > 2048 rows, so the previous default of 2000 was insufficient - Replace hardcoded `nb=2000` with `ct.default_nb` references for better maintainability - Add `default_nb` constant to RESTful v2 and replace hardcoded `nb=100`/`nb=200` with `nb=3000` | Module | Change | |--------|--------| | `python_client/common/common_type.py` | `default_nb = 2000` → `3000` | | `python_client/testcases/indexes/*` | 7 files: local `default_nb = 2000` → `ct.default_nb` | | `python_client/milvus_client/*` | 5 files: hardcoded `nb=2000` → `ct.default_nb` | | `python_client/milvus_client_v2/*` | 6 files: hardcoded `nb=2000` → `ct.default_nb` | | `python_client/testcases/*` | 3 files: hardcoded `nb=2000` → `ct.default_nb` | | `restful_client_v2/utils/constant.py` | Added `default_nb = 3000` | | `restful_client_v2/base/testbase.py` | `init_collection` default `nb=100` → `nb=3000` | | `restful_client_v2/utils/utils.py` | `get_data_by_payload` default `nb=100` → `nb=3000` | | `restful_client_v2/testcases/*` | 4 files: hardcoded `nb=100`/`nb=200` → `nb=3000` | issue: milvus-io#42446 --------- Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit 0a689a7)
Contributor
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
…lient_v2 testcases Replace all remaining hardcoded nb=3000 values with constant.default_nb references in RESTful v2 test files for better maintainability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
Change `from utils import constant` to `from utils.constant import default_nb` for cleaner variable references (default_nb instead of constant.default_nb). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
TEI embedding tests insert text data that requires embedding service calls per row. Using default_nb=3000 exceeds single request limits. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
- test_add_field_feature: replace hardcoded query_pks and boundary check with computed values based on ct.default_nb - test_milvus_client_json_path_index: use default_nb in error message - test_milvus_client_partial_update: use default_nb in error message Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
sre-ci-robot
added
size/XXL
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
Contributor
sre-ci-robot
added
size/XL
Contributor
|
@zhuwenxing Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
mergify
Bot
added
needs-dco
This reverts commit 884aafd. Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
zhuwenxing
force-pushed
the
cp_48787_to_2.6
branch
from
82e6d52 to
3f3a707
Compare
mergify
Bot
added
dco-passed
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
- Replace hardcoded nb=2000 with ct.default_nb in search_invalid and sparse_search tests - Fix hardcoded error message in upsert test to use dynamic default_nb values - Remove TestSearchByPK and TestSearchByPKNegative classes that don't exist on 2.6 Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
sre-ci-robot
added
size/L
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
Contributor
Author
|
/ci-rerun-gosdk |
2 similar comments
Contributor
Author
|
/ci-rerun-gosdk |
Contributor
Author
|
/ci-rerun-gosdk |
… nil pointer panic When NewMilvusClient fails in teardown(), mc is nil but code continues to call mc.Close() and mc.ListDatabase(), causing nil pointer dereference panic that masks actual test results (e.g. 591 tests PASS but CI reports FAIL). Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
yanliang567
added
ci-passed
manual-pass
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yanliang567, zhuwenxing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #48787 to 2.6 branch.
default_nbfrom 2000 to 3000 across Python client, RESTful v2, and index test modulesnb=2000/nb=100/nb=200/nb=3000withct.default_nb/default_nbreferences for better maintainabilitydefault_nbvaluesChanges
python_client/common/common_type.pydefault_nb = 2000→3000python_client/testcases/indexes/*default_nb = 2000→ct.default_nbpython_client/milvus_client/*nb=2000→ct.default_nbpython_client/milvus_client_v2/*nb=2000→ct.default_nbpython_client/testcases/*nb=2000→ct.default_nbrestful_client_v2/utils/constant.pydefault_nb = 3000restful_client_v2/base/testbase.pyinit_collectiondefaultnb=100→nb=3000restful_client_v2/utils/utils.pyget_data_by_payloaddefaultnb=100→nb=3000restful_client_v2/testcases/*nb=100/nb=200→default_nbCherry-pick differences from master
The following changes from #48787 were not applied because the corresponding code does not exist on the 2.6 branch:
testcases/indexes/test_hnsw_pq.pytestcases/indexes/test_hnsw_prq.pytestcases/test_large_topk.pymilvus_client/test_milvus_client_alter.pydefault_warmup_nbvariable does not exist on 2.6milvus_client_v2/test_milvus_client_search_string.pynb=2000code path on 2.6Additional 2.6-specific fixes not in the original PR:
test_milvus_client_upsert.py: Fixed hardcoded error message"previous length is 2000"→ dynamicdefault_nbvaluepr: #48787