Skip to content

Unify codegen tool and build directory handling#246

Merged
linmajia merged 2 commits into
microsoft:masterfrom
linmajia:fix
Jun 16, 2026
Merged

Unify codegen tool and build directory handling#246
linmajia merged 2 commits into
microsoft:masterfrom
linmajia:fix

Conversation

@linmajia

Copy link
Copy Markdown
Contributor

This PR cleans up rDSN build/codegen path handling across Windows and Unix-like platforms.

Changes

  • Remove the stale bin/Linux/thrift ignore entry.
  • Download missing Windows protoc.exe prebuilt tool.
  • Install Windows prebuilt thrift.exe and protoc.exe into builder/output/bin/${CMAKE_SYSTEM_NAME}, matching the Unix codegen tool layout.
  • Prefer built Windows protoc.exe when available, falling back to the downloaded prebuilt one.
  • Add DSN_BUILD_DIR support so build/test/install/publish/codegen can use a custom build directory instead of hardcoded builder.
  • Make Windows default build/test/install commands use builder, consistent with Unix.
  • Update Windows install documentation accordingly.
  • Avoid hardcoded top-level build paths in IDL codegen tests.

@linmajia linmajia merged commit 39a642d into microsoft:master Jun 16, 2026
2 checks passed
@linmajia linmajia deleted the fix branch June 16, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant