Skip to content

Fix Windows header and build style inconsistencies#244

Merged
linmajia merged 3 commits into
microsoft:masterfrom
linmajia:linmajia/fix
Jun 15, 2026
Merged

Fix Windows header and build style inconsistencies#244
linmajia merged 3 commits into
microsoft:masterfrom
linmajia:linmajia/fix

Conversation

@linmajia

Copy link
Copy Markdown
Contributor

Updates Windows-specific code style and build configuration:

  • Normalize Windows SDK header casing to lowercase, e.g. <windows.h>, <winsock2.h>, <tlhelp32.h>.
  • Ensure Winsock headers are included before <windows.h>.
  • Move Windows system library dependencies from source pragmas into CMake via DSN_SYSTEM_LIBS.
  • Add ws2_32 and psapi for Windows builds.
  • Fix the ntohl/htonl helper type check in ports.h to use u_long.
  • Normalize Windows conditional include ordering in main.cpp and service_api_c.cpp.

HX Lin and others added 3 commits June 15, 2026 10:24
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@linmajia linmajia merged commit 7b2aa70 into microsoft:master Jun 15, 2026
2 checks passed
@linmajia linmajia deleted the linmajia/fix branch June 15, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant