fix(unix): don't rewrite app.asar.unpacked paths a second time#924
Open
arthur791004 wants to merge 1 commit into
Open
fix(unix): don't rewrite app.asar.unpacked paths a second time#924arthur791004 wants to merge 1 commit into
arthur791004 wants to merge 1 commit into
Conversation
helperPath.replace('app.asar', 'app.asar.unpacked') matches the first
occurrence. When helperPath already contains 'app.asar.unpacked/...'
(e.g. a caller of node-pty that itself lives inside app.asar.unpacked,
bypassing Electron's asar shim), the substring 'app.asar' matches the
prefix of 'app.asar.unpacked' and we produce 'app.asar.unpacked.unpacked/...'
— a path that doesn't exist on disk. posix_spawn then fails with ENOENT
and node-pty throws the misleading "posix_spawnp failed.".
Skip each rewrite when the unpacked variant is already present.
Fixes microsoft#923.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #923.
src/unixTerminal.ts#L19-L20does:String.prototype.replacewith a string argument matches the first occurrence. When the resolved `helperPath` already contains `app.asar.unpacked/…` (e.g. a caller of node-pty that itself lives inside `app.asar.unpacked`, bypassing Electron's asar shim — see #923 for the concrete repro), the substring `app.asar` matches the prefix of `app.asar.unpacked` and we produce a bogus `…/app.asar.unpacked.unpacked/…` path. `posix_spawn` then fails with `ENOENT` and node-pty surfaces the misleading `posix_spawnp failed.`.This PR guards each rewrite so it only fires when the unpacked variant isn't already present.
Test plan