Skip to content

Update Managed Lustre test recordings#2376

Merged
alzimmermsft merged 1 commit intomicrosoft:mainfrom
alzimmermsft:FixManagedLustreRecordings
Apr 9, 2026
Merged

Update Managed Lustre test recordings#2376
alzimmermsft merged 1 commit intomicrosoft:mainfrom
alzimmermsft:FixManagedLustreRecordings

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

What does this PR do?

Regenerate Managed Lustre test recordings to add back request/responses that were previously removed by Fix-TestRecording.ps1 as that functionality is no longer needed as polling intervals now use 1 millisecond when running in playback.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure Managed Lustre recorded-test setup by removing the no-longer-needed recording “fix-up” script and switching the tests to use a shared helper for fast playback polling, along with updating the referenced assets tag for refreshed recordings.

Changes:

  • Deleted the Fix-TestRecording.ps1 script that previously removed consecutive InProgress responses from recordings.
  • Updated Managed Lustre live tests to use a centralized PollInterval(...) helper (1ms in playback, configurable in live/record).
  • Bumped the assets.json tag to point at the regenerated Managed Lustre recordings in the assets repo.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tools/Azure.Mcp.Tools.ManagedLustre/tests/Fix-TestRecording.ps1 Removes the obsolete script used to post-process recordings.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs Switches delays/polling to PollInterval(...) to keep playback fast without manual recording trimming.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/assets.json Updates the assets tag to reference the newly regenerated recordings.
core/Microsoft.Mcp.Core/tests/Microsoft.Mcp.Tests/Client/RecordedCommandTestsBase.cs Adds PollInterval(long) helper to standardize playback vs live polling intervals.

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Apr 9, 2026
@alzimmermsft alzimmermsft merged commit e63d44a into microsoft:main Apr 9, 2026
31 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Apr 9, 2026
@alzimmermsft alzimmermsft deleted the FixManagedLustreRecordings branch April 9, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-managedlustre Azure Managed Lustre

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants