Update Managed Lustre test recordings#2376
Merged
alzimmermsft merged 1 commit intomicrosoft:mainfrom Apr 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Managed Lustre recorded-test setup by removing the no-longer-needed recording “fix-up” script and switching the tests to use a shared helper for fast playback polling, along with updating the referenced assets tag for refreshed recordings.
Changes:
- Deleted the
Fix-TestRecording.ps1script that previously removed consecutiveInProgressresponses from recordings. - Updated Managed Lustre live tests to use a centralized
PollInterval(...)helper (1ms in playback, configurable in live/record). - Bumped the
assets.jsontag to point at the regenerated Managed Lustre recordings in the assets repo.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Fix-TestRecording.ps1 | Removes the obsolete script used to post-process recordings. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs | Switches delays/polling to PollInterval(...) to keep playback fast without manual recording trimming. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/assets.json | Updates the assets tag to reference the newly regenerated recordings. |
| core/Microsoft.Mcp.Core/tests/Microsoft.Mcp.Tests/Client/RecordedCommandTestsBase.cs | Adds PollInterval(long) helper to standardize playback vs live polling intervals. |
rebecca-makar
approved these changes
Apr 9, 2026
hallipr
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Regenerate Managed Lustre test recordings to add back request/responses that were previously removed by
Fix-TestRecording.ps1as that functionality is no longer needed as polling intervals now use 1 millisecond when running in playback.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline