-
Notifications
You must be signed in to change notification settings - Fork 86
feat(open): add 'open vscode' and 'open ssms', remove retired 'open ads' #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dlevy-msft-sql
wants to merge
71
commits into
microsoft:main
Choose a base branch
from
dlevy-msft-sql:pr-685
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
94e8d63
feat(open): add sqlcmd open vscode and sqlcmd open ssms commands
dlevy-msft-sql 3b31493
fix: handle JSONC in VS Code settings.json and use atomic write
dlevy-msft-sql 2d66bd7
fix: prevent TestVSCode from writing to real settings.json
dlevy-msft-sql 328f223
fix: suppress errcheck lint for best-effort os.Remove on cleanup paths
dlevy-msft-sql de6bd33
fix: RunWithOutput stdout conflict and clipboard security warning
dlevy-msft-sql 6471a22
i18n: localize Linux clipboard fallback error
dlevy-msft-sql e6edcc2
feat: remove sqlcmd open ads (Azure Data Studio retired)
dlevy-msft-sql 581a975
feat(open): launch SSMS via ssms:// URL handler with registry-based d…
dlevy-msft-sql b5fdd02
revert: launch SSMS via ssms:// URL handler
dlevy-msft-sql 1081169
feat(open): discover SSMS via vswhere and add --version flag
dlevy-msft-sql 5268f50
feat(open): add --build flag and build-aware VS Code discovery
dlevy-msft-sql 2843507
fix(tools): include exe name as argv[0] on Windows so first flag is n…
dlevy-msft-sql 8a576d2
fix(tools): launch tools detached so sqlcmd returns immediately
dlevy-msft-sql 168b08b
fix(open): connect via mssql --open-url instead of opening empty window
dlevy-msft-sql 0798901
fix(tools): redirect gui child stdio to null device so sqlcmd exits
dlevy-msft-sql 12c4753
feat(open): finalize vscode launch for mssql extension
dlevy-msft-sql 68cba80
fix(open): satisfy golangci-lint (errcheck, QF1007)
dlevy-msft-sql c7ea7a0
fix(open): return empty string when container inspect fails
dlevy-msft-sql 419e1cf
fix(open): use Mandatory encrypt enum and honor VSCODE_EXTENSIONS
dlevy-msft-sql 13d80a9
refactor(open): drop ai-slop comments and tautological clipboard tests
dlevy-msft-sql e102968
fix(tools): launch macOS vscode via in-bundle binary not the .app dir…
dlevy-msft-sql d094eee
fix(open): pass ssms username argv raw without bogus shell-escape
dlevy-msft-sql 1d6044c
fix(open): back up settings.json when vscode comments would be lost
dlevy-msft-sql 9720559
refactor(open): drop dead vscode RunWithOutput and tautological tests
dlevy-msft-sql eb9a63a
revert: keep macOS vscode searchLocations on the .app bundle
dlevy-msft-sql 496849d
fix(open): don't claim mssql extension install succeeded when we only…
dlevy-msft-sql b790eea
fix(tools): detach stdio when /dev/null open fails to avoid pipe-drai…
dlevy-msft-sql e7925b0
test(open): assert full settings.json path tail per OS not just Code
dlevy-msft-sql db49928
refactor(open): drop --install-extension; vscode:// URL already prompts
dlevy-msft-sql 960bb98
docs: address PR feedback on open vscode/ssms
dlevy-msft-sql 51baca8
refactor(tools): drop unused RunWithOutput and stale --install-extens…
dlevy-msft-sql 95e916e
fix(i18n): restore translation catalog after rebase
dlevy-msft-sql fcaf561
fix(open): drop tcp: prefix and base64-encode test password
dlevy-msft-sql 1c87f52
feat(open): platform-conditional vscode/ssms hints in help
dlevy-msft-sql f07ddab
test(ssms): cover partial-install case; drop trivial Name() test
dlevy-msft-sql a37266e
refactor(open): preserve vscode settings.json comments via hujson
dlevy-msft-sql 1675185
feat(open): enable 'sqlcmd open' on linux
dlevy-msft-sql 9604050
refactor(root): drop tautological GOOS gate on open subcommand
dlevy-msft-sql 2d60ac6
fix(open): resolve vscode settings path for snap, XDG, and missing HOME
dlevy-msft-sql 1876351
fix(open): scope persisted credentials and clipboard copy to the inst…
dlevy-msft-sql d769749
fix: address copilot review on PR #688
dlevy-msft-sql 1e8f29a
chore: remove accidentally committed scratch files
dlevy-msft-sql 4a513f5
fix(container): return empty string when ContainerName called with em…
dlevy-msft-sql 54fe8a7
fix(open): use platform-appropriate home-dir hint
dlevy-msft-sql e0e7bad
fix: address copilot review on basic auth guard and ssms help text
dlevy-msft-sql c2b2e37
fix: localize home directory error and ssms_unix fatal message
dlevy-msft-sql 22e1955
fix: address copilot review on argv normalization, home dir nil err, …
dlevy-msft-sql 7c69a69
refactor: hoist ssms struct and DefineCommand to untagged file
dlevy-msft-sql 1118c5b
fix: verify vscode install before writing settings; harden code shim …
dlevy-msft-sql 3a16f29
refactor: rename Ssms type to SSMS for acronym consistency
dlevy-msft-sql e414939
fix: detect early-exit failures in tool.Run and show SSMS install help
dlevy-msft-sql b8bc282
fix: guard copyPasswordToClipboard against nil output
dlevy-msft-sql 94ff696
test: gate COMSPEC-based tool tests to Windows
dlevy-msft-sql 16d19cf
docs: update tool.Run stdio comment to match Wait goroutine
dlevy-msft-sql 8bb6015
fix: restrict isLocalEndpoint to container-backed endpoints
dlevy-msft-sql b06382f
fix: drop redundant port field from vscode mssql profile
dlevy-msft-sql dcb21bf
fix: resolve clip.exe via SystemRoot to avoid PATH hijack
dlevy-msft-sql 8f5c674
fix: clean up vscode connection profile when sqlcmd delete runs
dlevy-msft-sql dd4434c
fix: harden Windows path fallbacks for clip.exe and VS Code probing
dlevy-msft-sql c3c6089
fix(open): fail fast on 'open vscode' and 'open ssms' with no current…
dlevy-msft-sql da7acdb
fix(open): guard linux/darwin VS Code probes against empty HOME
dlevy-msft-sql 268315e
refactor: drop restate-the-code comments from open/clipboard files
dlevy-msft-sql 5505434
feat: stage password to clipboard for VS Code remote SQL auth
dlevy-msft-sql af144b3
test: reset shared config between open tests to make them order-indep…
dlevy-msft-sql 6e6ae83
fix: harden vscode settings dir perms, pin pbcopy path, isolate more …
dlevy-msft-sql 05be752
fix: pin linux clipboard helper to LookPath result to prevent PATH races
dlevy-msft-sql 3701550
fix: suggest install options when linux clipboard helper is missing
dlevy-msft-sql 432486c
fix: list per-WM install commands in linux clipboard error
dlevy-msft-sql e600213
fix(open vscode): launch via in-bundle code CLI on macOS
dlevy-msft-sql bc405e4
fix(config add-endpoint): don't apply locale thousands separator to port
dlevy-msft-sql a3aae09
refactor(open): trim restate-the-code and dramatic comments
dlevy-msft-sql File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.