feat: support SQL database creation with initial properties#250
Open
v-alexmoraru wants to merge 4 commits into
Open
feat: support SQL database creation with initial properties#250v-alexmoraru wants to merge 4 commits into
v-alexmoraru wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for creating SQL_DATABASE items with an optional creationPayload so initial SQL Database properties (and creation mode) can be set at creation time.
Changes:
- Add
_build_sql_database_creation_payload(and backup retention validation) and wire it intoadd_type_specific_payloadforItemType.SQL_DATABASE. - Introduce new SQL Database constants (creation modes, backup retention bounds) and CommonErrors helpers for validation messaging.
- Add unit tests covering payload generation and validation scenarios; add a changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_utils/test_fab_cmd_mkdir_utils.py | Adds tests for SQLDatabase creation payload building/validation. |
| src/fabric_cli/utils/fab_cmd_mkdir_utils.py | Builds/validates SQLDatabase creationPayload and attaches it during mkdir. |
| src/fabric_cli/errors/common.py | Adds error message helpers for SQLDatabase creation mode/property validation. |
| src/fabric_cli/core/fab_constant.py | Adds SQLDatabase constants for creation modes and backup retention limits. |
| .changes/unreleased/added-20260618-043404.yaml | Records changelog entry for the new SQL db creation support. |
ayeshurun
reviewed
Jun 23, 2026
| backup_retention_days = params.get("backupretentiondays") | ||
| collation = params.get("collation") | ||
|
|
||
| if mode is None and backup_retention_days is None and collation is None: |
Collaborator
There was a problem hiding this comment.
what if one of them isnt none? what should be the outcome?
ayeshurun
reviewed
Jun 23, 2026
Comment on lines
+223
to
+225
| creation_payload = _build_sql_database_creation_payload(params) | ||
| if creation_payload: | ||
| payload_dict["creationPayload"] = creation_payload |
Collaborator
There was a problem hiding this comment.
Suggested change
| creation_payload = _build_sql_database_creation_payload(params) | |
| if creation_payload: | |
| payload_dict["creationPayload"] = creation_payload | |
| creation_payload = _build_sql_database_creation_payload_if_exists(params) | |
| if creation_payload: | |
| payload_dict["creationPayload"] = creation_payload |
ayeshurun
reviewed
Jun 23, 2026
Comment on lines
+834
to
+835
| else: | ||
| mode = fab_constant.SQL_DATABASE_CREATION_MODE_NEW |
Collaborator
There was a problem hiding this comment.
why we need to set something at all if not provided?
ayeshurun
reviewed
Jun 23, 2026
| raise ValueError() | ||
| except (ValueError, TypeError): | ||
| raise FabricCLIError( | ||
| CommonErrors.invalid_backup_retention_days(str(value), min_days, max_days), |
Collaborator
There was a problem hiding this comment.
in the other pr you already doing it, consider having one pr that implements both.
ayeshurun
reviewed
Jun 23, 2026
| if mode is None and backup_retention_days is None and collation is None: | ||
| return None | ||
|
|
||
| # Resolve and validate mode |
Collaborator
There was a problem hiding this comment.
i dont think we should validate the creationPayload input, it is the workload responsibility. we do need to make sure we support creating the artifact with those optional params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148.
Builds proper payload for creation of SQL databases with initial properties such as backup retention days, mode or collation.