Skip to content

Load settings before parsing args #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UnnaturalTwilight wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

Load settings before parsing args #875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions crates/edit/src/bin/edit/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,18 @@ fn run() -> apperr::Result<()> {
localization::init();

let mut state = State::new()?;

// Load settings so user file associations are ready when opening files passed as args
if let Err(err) = Settings::reload() {
state.add_error(err);
}

if handle_args(&mut state)? {
return Ok(());
}

handle_stdin(&mut state)?;

if let Err(err) = Settings::reload() {
state.add_error(err);
}

// Switch the terminal to raw mode which prevents the user from pressing Ctrl+C.
// `handle_args` may want to print a help message (must not fail),
// and reads files (may hang; should be cancelable with Ctrl+C).
Expand Down
Loading