Skip to content

build: fixup 2.102.0 release prep (asserts + missed changesets)#27435

Merged
dannimad merged 3 commits into
mainfrom
release-prep/2.102.0/5-fixup-asserts-and-notes
May 28, 2026
Merged

build: fixup 2.102.0 release prep (asserts + missed changesets)#27435
dannimad merged 3 commits into
mainfrom
release-prep/2.102.0/5-fixup-asserts-and-notes

Conversation

@dannimad
Copy link
Copy Markdown
Contributor

Description

Two follow-ups after #27399, #27400, #27401 merged:

1. Six new untagged asserts in @fluidframework/tree

Landed via #27200 (field batch format work):

  • packages/dds/tree/src/feature-libraries/chunked-forest/codec/chunkDecoding.ts (5)
  • packages/dds/tree/src/simple-tree/core/treeNodeKernel.ts (1)

Tagged with codes 0xcfb0xd00 via pnpm run policy-check:asserts.

2. Two changesets missed by #27401's release-notes generation

.changeset/soft-beds-beam.md and .changeset/zesty-otters-collab.md from
#27212 landed after I ran the release-notes generation locally but before
#27401 merged, so they were not picked up by the 2.102.0 release notes or
changelogs.

Followed the documented revert-and-regenerate flow from
.claude/skills/fluid-release/references/minor-release-prep.md:

  1. Reverted build: add release notes and changelogs for 2.102.0 #27401 (squash commit cf7e1891a4) to restore the two original
    changesets.
  2. Ran pnpm flub generate releaseNotes -g client -t minor (now sees all 4).
  3. Ran pnpm flub generate changelog -g client (consumes all 4 changesets).
  4. Manually fixed PR/commit refs for the two restored changesets — flub had
    pointed them at the revert commit (5b7ce7075f / #27401) instead of their
    original PRs. Corrected in:

The two new changesets (soft-beds-beam, zesty-otters-collab) keep correct
refs from their original PR #27212.

Merge order

This PR must merge before #27402 (the 2.103.0 version bump).
After this merges, #27402 will need a rebase onto updated main (new
packageVersion.ts files added by #27200 also need to bump to 2.103.0).

Reviewer Guidance

The review process is outlined on this wiki page.

Please skim RELEASE_NOTES/2.102.0.md — it should now have 4 entries across
✨ Features (1), Legacy API Changes (1), Deprecations (1), and Legacy (1).

dannimad and others added 2 commits May 28, 2026 19:16
Two follow-ups discovered after #27399, #27400, #27401 merged:

1. Six new untagged asserts landed in @fluidframework/tree
   (chunkDecoding.ts, treeNodeKernel.ts) from #27200. Tagged via
   pnpm run policy-check:asserts (codes 0xcfb-0xd00).

2. Two new changesets (soft-beds-beam, zesty-otters-collab) landed via
   #27212 after the release-notes generation in #27401 but before #27401
   merged, so they were not picked up. Re-ran the documented
   revert-and-regenerate flow:

   - Reverted #27401 to restore the original two changesets.
   - Ran flub generate releaseNotes (all 4 entries) and
     flub generate changelog (all 4 entries).
   - Manually fixed PR and commit refs for the two restored changesets
     in fluid-framework, core-utils, and container-definitions
     CHANGELOG.md files (flub had pointed them at the revert commit
     instead of their original PRs #27282 and #27269).

This PR replaces #27401 and must merge before #27402 (the version
bump).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 28, 2026 19:19
@dannimad dannimad requested review from a team as code owners May 28, 2026 19:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (126 lines, 11 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

The disposed-kernel registration assert in TreeNodeKernel.events was tagged
with shortcode 0xcfa during 2.102.0 release prep, so its runtime error
message is now the hex code rather than the human-readable string. Use
validateAssertionError(/.../) which looks up the assert text via the
assertionShortCodesMap.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  288859 links
    1925 destination URLs
    2175 URLs ignored
       0 warnings
       0 errors


@dannimad dannimad enabled auto-merge (squash) May 28, 2026 20:57
@dannimad dannimad merged commit 8d97018 into main May 28, 2026
39 checks passed
@dannimad dannimad deleted the release-prep/2.102.0/5-fixup-asserts-and-notes branch May 28, 2026 21:18
dannimad added a commit that referenced this pull request May 28, 2026
Bump client release group from 2.102.0 to 2.103.0 for ongoing development on
`main` following the 2.102.0 release. Generated by
`pnpm flub bump client --exact 2.103.0 --no-commit`.

This is the final release-prep PR for 2.102.0 and **must merge last**, after:
- #27399 (tag asserts)
- #27400 (compat-gen)
- #27401 (release notes + changelogs)
- #27435 (fixup: asserts + missed changesets)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
dannimad added a commit that referenced this pull request May 28, 2026
## Description

Bump the client release group from 2.102.0 to 2.103.0 for ongoing
development
on `main` following the 2.102.0 release.

Generated by:
- `pnpm flub bump client --exact 2.103.0 --no-commit`

All 209 modified files are single-line `version` / `pkgVersion` string
changes
in `package.json` and `packageVersion.ts`.

This is the final release-prep PR for 2.102.0 and **must merge LAST**,
after:
- #27399 (tag asserts) — merged
- #27400 (compat-gen) — merged
- #27401 (release notes + changelogs) — merged
- #27435 (fixup: asserts + missed changesets) — merged

After this PR merges, the release branch `release/client/2.102` will be
cut
from the commit immediately before this bump.

## Update history

The branch was regenerated on top of fresh `main` after the prior
release-prep
PRs (#27401, #27435) and an additional feature PR (#27348 —
`driver-web-cache`)
landed. The new `driver-web-cache` `packageVersion.ts` is now included
in the
bump (it did not exist when the original commit was authored).
Force-pushed
with `--force-with-lease`.

## Reviewer Guidance

The review process is outlined on [this wiki
page](https://github.com/microsoft/FluidFramework/wiki/PR-Guidelines#guidelines).

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants