build: fixup 2.102.0 release prep (asserts + missed changesets)#27435
Merged
Conversation
This reverts commit cf7e189.
Two follow-ups discovered after #27399, #27400, #27401 merged: 1. Six new untagged asserts landed in @fluidframework/tree (chunkDecoding.ts, treeNodeKernel.ts) from #27200. Tagged via pnpm run policy-check:asserts (codes 0xcfb-0xd00). 2. Two new changesets (soft-beds-beam, zesty-otters-collab) landed via #27212 after the release-notes generation in #27401 but before #27401 merged, so they were not picked up. Re-ran the documented revert-and-regenerate flow: - Reverted #27401 to restore the original two changesets. - Ran flub generate releaseNotes (all 4 entries) and flub generate changelog (all 4 entries). - Manually fixed PR and commit refs for the two restored changesets in fluid-framework, core-utils, and container-definitions CHANGELOG.md files (flub had pointed them at the revert commit instead of their original PRs #27282 and #27269). This PR replaces #27401 and must merge before #27402 (the version bump). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (126 lines, 11 files), I've queued these reviewers:
How this works
|
CraigMacomber
approved these changes
May 28, 2026
The disposed-kernel registration assert in TreeNodeKernel.events was tagged with shortcode 0xcfa during 2.102.0 release prep, so its runtime error message is now the hex code rather than the human-readable string. Use validateAssertionError(/.../) which looks up the assert text via the assertionShortCodesMap. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
alexvy86
approved these changes
May 28, 2026
dannimad
added a commit
that referenced
this pull request
May 28, 2026
Bump client release group from 2.102.0 to 2.103.0 for ongoing development on `main` following the 2.102.0 release. Generated by `pnpm flub bump client --exact 2.103.0 --no-commit`. This is the final release-prep PR for 2.102.0 and **must merge last**, after: - #27399 (tag asserts) - #27400 (compat-gen) - #27401 (release notes + changelogs) - #27435 (fixup: asserts + missed changesets) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
dannimad
added a commit
that referenced
this pull request
May 28, 2026
## Description Bump the client release group from 2.102.0 to 2.103.0 for ongoing development on `main` following the 2.102.0 release. Generated by: - `pnpm flub bump client --exact 2.103.0 --no-commit` All 209 modified files are single-line `version` / `pkgVersion` string changes in `package.json` and `packageVersion.ts`. This is the final release-prep PR for 2.102.0 and **must merge LAST**, after: - #27399 (tag asserts) — merged - #27400 (compat-gen) — merged - #27401 (release notes + changelogs) — merged - #27435 (fixup: asserts + missed changesets) — merged After this PR merges, the release branch `release/client/2.102` will be cut from the commit immediately before this bump. ## Update history The branch was regenerated on top of fresh `main` after the prior release-prep PRs (#27401, #27435) and an additional feature PR (#27348 — `driver-web-cache`) landed. The new `driver-web-cache` `packageVersion.ts` is now included in the bump (it did not exist when the original commit was authored). Force-pushed with `--force-with-lease`. ## Reviewer Guidance The review process is outlined on [this wiki page](https://github.com/microsoft/FluidFramework/wiki/PR-Guidelines#guidelines). Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two follow-ups after #27399, #27400, #27401 merged:
1. Six new untagged asserts in
@fluidframework/treeLanded via #27200 (field batch format work):
packages/dds/tree/src/feature-libraries/chunked-forest/codec/chunkDecoding.ts(5)packages/dds/tree/src/simple-tree/core/treeNodeKernel.ts(1)Tagged with codes
0xcfb–0xd00viapnpm run policy-check:asserts.2. Two changesets missed by #27401's release-notes generation
.changeset/soft-beds-beam.mdand.changeset/zesty-otters-collab.mdfrom#27212 landed after I ran the release-notes generation locally but before
#27401 merged, so they were not picked up by the 2.102.0 release notes or
changelogs.
Followed the documented revert-and-regenerate flow from
.claude/skills/fluid-release/references/minor-release-prep.md:cf7e1891a4) to restore the two originalchangesets.
pnpm flub generate releaseNotes -g client -t minor(now sees all 4).pnpm flub generate changelog -g client(consumes all 4 changesets).flubhadpointed them at the revert commit (
5b7ce7075f/#27401) instead of theiroriginal PRs. Corrected in:
packages/framework/fluid-framework/CHANGELOG.md→ Promote onAssertionFailure to beta #27282 /4191b82e41packages/common/core-utils/CHANGELOG.md→ Promote onAssertionFailure to beta #27282 /4191b82e41packages/common/container-definitions/CHANGELOG.md→ feat: add optional getPendingLocalState to IContainer #27269 /1f12b8e36eThe two new changesets (soft-beds-beam, zesty-otters-collab) keep correct
refs from their original PR #27212.
Merge order
This PR must merge before #27402 (the 2.103.0 version bump).
After this merges, #27402 will need a rebase onto updated
main(newpackageVersion.tsfiles added by #27200 also need to bump to 2.103.0).Reviewer Guidance
The review process is outlined on this wiki page.
Please skim
RELEASE_NOTES/2.102.0.md— it should now have 4 entries across✨ Features (1), Legacy API Changes (1), Deprecations (1), and Legacy (1).