Skip to content

Disable some slow low value lints for tests in tree#27432

Merged
CraigMacomber merged 3 commits into
microsoft:mainfrom
CraigMacomber:slowTestLint
May 29, 2026
Merged

Disable some slow low value lints for tests in tree#27432
CraigMacomber merged 3 commits into
microsoft:mainfrom
CraigMacomber:slowTestLint

Conversation

@CraigMacomber
Copy link
Copy Markdown
Contributor

Description

This improves lint time for tree from 53 seconds to 44 (or 27 to 22.5 when combined with #27431

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings May 28, 2026 01:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (14 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces lint time for the @fluidframework/tree package by disabling several expensive ESLint rules specifically for test files (src/test/**/*), where their signal is considered low relative to their runtime cost.

Changes:

  • Disable promise-related lint rules in test files (@typescript-eslint/no-misused-promises, @typescript-eslint/no-floating-promises).
  • Disable additional high-cost rules for tests (@typescript-eslint/strict-boolean-expressions, import-x/namespace, unicorn/better-regex).
  • Add inline documentation grouping these disabled rules as a performance-focused override for tests.

Comment thread packages/dds/tree/eslint.config.mts Outdated
Comment thread packages/dds/tree/eslint.config.mts Outdated
@CraigMacomber CraigMacomber merged commit e7fa1db into microsoft:main May 29, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants