Disable some slow low value lints for tests in tree#27432
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (14 lines, 1 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
This PR reduces lint time for the @fluidframework/tree package by disabling several expensive ESLint rules specifically for test files (src/test/**/*), where their signal is considered low relative to their runtime cost.
Changes:
- Disable promise-related lint rules in test files (
@typescript-eslint/no-misused-promises,@typescript-eslint/no-floating-promises). - Disable additional high-cost rules for tests (
@typescript-eslint/strict-boolean-expressions,import-x/namespace,unicorn/better-regex). - Add inline documentation grouping these disabled rules as a performance-focused override for tests.
Description
This improves lint time for tree from 53 seconds to 44 (or 27 to 22.5 when combined with #27431
Reviewer Guidance
The review process is outlined on this wiki page.