tree: Fix bug with updating node parentage in sequence composition#27387
tree: Fix bug with updating node parentage in sequence composition#27387alex-pardes wants to merge 3 commits into
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (7 lines, 2 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
Fixes sequence-field composition so that when composing move-related node changes (modifyAfter), the cross-field manager is notified via onMoveIn, preventing incorrect node ancestry/parentage in the composed changeset.
Changes:
- Removes
onMoveIninvocation fromComposeQueue.dequeueBase. - Invokes
moveEffects.onMoveIn(...)whenmodifyAfteris retrieved ingetModifyAfter, ensuring it also runs in cases likedequeueBoth.
| if (effect.value?.modifyAfter !== undefined) { | ||
| moveEffects.onMoveIn(effect.value.modifyAfter); | ||
| return effect.value.modifyAfter; |
Description
Fixed a bug where sequence field failed to call
onMoveInin some cases when moving a node changeset during composition. This would lead to the composed changeset having incorrect node ancestry information, which could cause problems during other operations.