Update AuthServerCheck, EWSVirtualDirectoryCheckOAuth, CheckIfExchang…#2533
Open
MarcoLFrancisco wants to merge 3 commits into
Open
Update AuthServerCheck, EWSVirtualDirectoryCheckOAuth, CheckIfExchang…#2533MarcoLFrancisco wants to merge 3 commits into
MarcoLFrancisco wants to merge 3 commits into
Conversation
…eServer, CheckParameters, hostOutputIntraOrgConEnabled, and HTML configuration rendering to align on-prem hybrid free/busy OAuth validation with modern EvoSTS-based auth and fix related output issues
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates FreeBusyChecker’s on-prem hybrid Free/Busy OAuth validation to align with modern EvoSTS-based hybrid authentication, and fixes related output/rendering behavior.
Changes:
- Switch AuthServer validation from legacy ACS patterns to EvoSTS (Realm/IssuerIdentifier/TokenIssuingEndpoint/AuthMetadataUrl).
- Adjust HTML/host output paths for OAuth vs DAuth and improve configuration section markup.
- Refactor Exchange server detection and EWS virtual directory data retrieval used by OAuth checks.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Diagnostics/FreeBusyChecker/Functions/htmlContent.ps1 | Fixes HTML heading markup for the configuration section. |
| Diagnostics/FreeBusyChecker/Functions/hostOutput.ps1 | Corrects which HTML lookup output is used when running OAuth-only. |
| Diagnostics/FreeBusyChecker/Functions/OnPremOAuthFunctions.ps1 | Updates AuthServer checks to EvoSTS and ensures EWS info fetch occurs before OAuth validation. |
| Diagnostics/FreeBusyChecker/Functions/CommonFunctions.ps1 | Refactors Exchange server validation and parameter checks; adjusts EWS info caching behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Suggestion accepted Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dpaulson45
reviewed
May 4, 2026
Suggestion accepted Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
@MarcoLFrancisco can you review the comments that I made and make the required changes. |
Contributor
Author
|
Reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Update on-prem Hybrid Free/Busy OAuth validation to match modern hybrid authentication behavior.
Reason:
The previous validation logic was checking older ACS-based values and had a few related output/parameter issues that did not align with current EvoSTS-based hybrid OAuth configuration.
Fix:
Updated AuthServerCheck, EWSVirtualDirectoryCheckOAuth, CheckIfExchangeServer, CheckParameters, hostOutputIntraOrgConEnabled, and related HTML output to validate the expected modern on-prem hybrid OAuth configuration and correct output behavior.
Validation:
Reviewed the updated output logic and rebuilt this change as a clean PR from current upstream/main with only the intended FreeBusyChecker function changes.