[Subcontracting] Performance issues fix

[AleksandricMarko]

Summary

Work Item(s)

Fixes AB#623643

[github-actions]

AL Documentation Audit

Documentation gaps were detected in the following apps:

• Subcontracting: 10% documentation coverage

To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.

[github-actions]

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

---

🔄 How to trigger a new status check:

1. 📤 Push a new commit to the PR branch, or
2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

[AleksandricMarko]

Hello @SPinkow @stevengrossGOB
Could you please review this PR
Seems like there was a bug with if ItemLedgerEntry.IsEmpty() then (should be if ItemLedgerEntry2.IsEmpty() then)
Also, in 2 procedures DeleteSubcontractingDependentPurchaseLines was done, does it make sense to have same Purchase Line filters?

Both in file src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcSynchronizeManagement.Codeunit.al

[SPinkow]

If I read this then I am not sure what we want to ensure here. Mabe the originally intention was to check if the transfer order has any item ledger entries yet? I think that we only want to delete the transfer order if nothing has been posted so far.
Using the same filtering as for ItemLedgerEntry Variable makes no sense because the ItemLedgerEntry2.IsEmpty will always be true because it would equal one of the if statements above in this procedure. If we filter on transfer item ledger entries the TransferHeader will only be deleted if there are no transfer postings. We are in the case of switching the vendor no so ifthere are some postings on the wrong vendor the user must have the possibility to finish posting the transfer and it should not be deleted.