Fix solve e40b9e2f#10
Open
AmziJeffs wants to merge 2 commits intomichaelhodel:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current solver has an error in line 3933
x10 = argmax(x9, x5). The code attempts to find the translate of maximum overlap with original object, but the functionx5simply computes the intersection, not the size of the intersection.The second overlap computation in the solver is correct, using
x14 = compose(size, x5)to find the argmax of size. The simplest fix is to just definex14earlier, and use it in the first argmax instead ofx5. My fix does this, and renames the variables sequentially.