Add tests for interpolate_diskarray function#67
Conversation
These are partially broken.
this removes ... if the window length is less then 4
Coverage Report for CI Build 26826105776Coverage increased (+12.2%) to 57.949%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
===========================================
+ Coverage 45.75% 57.94% +12.19%
===========================================
Files 23 23
Lines 2133 2145 +12
===========================================
+ Hits 976 1243 +267
+ Misses 1157 902 -255 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nice, thank you! Any idea why the tests are not failing? |
|
CI is not failing, because I forgot to include the test_interpolation file |
|
I included test_interpolation.jl into runtests.jl and fixed the tests. These are now succeding because I commented the range dispatch of getinterpinds. We could also just leave it like that for now and look at the range method for getinterpinds if this is really the bottleneck for some application. |
|
This is missing tests for the show functions for GMWOPResults and LoopWindows |
|
Yes let's leave this as it is right now. One or 2 tests for the new print methods would be great, even if only skeleton. I will look into extending the GMWOPResult show method tomorrow. |
|
Ok I just pushed some tests for GMWOPResult including show methods. Ideally I would like to merge and make a release. |
felixcremer
left a comment
There was a problem hiding this comment.
Looks good to me.
This also adds tests for aggregate and some printing changes.
@meggart I haven't done the fully inner test yet, but the other two are in the test_interpolation file.