Skip to content

Add tests for interpolate_diskarray function#67

Merged
felixcremer merged 9 commits into
mainfrom
fc/aggregate
Jun 2, 2026
Merged

Add tests for interpolate_diskarray function#67
felixcremer merged 9 commits into
mainfrom
fc/aggregate

Conversation

@felixcremer

Copy link
Copy Markdown
Collaborator

This also adds tests for aggregate and some printing changes.

@meggart I haven't done the fully inner test yet, but the other two are in the test_interpolation file.

@coveralls

coveralls commented May 18, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26826105776

Coverage increased (+12.2%) to 57.949%

Details

  • Coverage increased (+12.2%) from the base build.
  • Patch coverage: 17 uncovered changes across 3 files (0 of 17 lines covered, 0.0%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
src/diskarrayresults.jl 9 0 0.0%
src/mwops.jl 6 0 0.0%
src/graphs.jl 2 0 0.0%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
src/mwops.jl 1 51.55%

Coverage Stats

Coverage Status
Relevant Lines: 2145
Covered Lines: 1243
Line Coverage: 57.95%
Coverage Strength: 211.36 hits per line

💛 - Coveralls

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.94%. Comparing base (4808ae7) to head (c19bbc7).

Files with missing lines Patch % Lines
src/diskarrayresults.jl 0.00% 9 Missing ⚠️
src/mwops.jl 0.00% 6 Missing ⚠️
src/graphs.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #67       +/-   ##
===========================================
+ Coverage   45.75%   57.94%   +12.19%     
===========================================
  Files          23       23               
  Lines        2133     2145       +12     
===========================================
+ Hits          976     1243      +267     
+ Misses       1157      902      -255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meggart

meggart commented May 18, 2026

Copy link
Copy Markdown
Owner

Nice, thank you! Any idea why the tests are not failing?

@felixcremer

Copy link
Copy Markdown
Collaborator Author

CI is not failing, because I forgot to include the test_interpolation file

@felixcremer

Copy link
Copy Markdown
Collaborator Author

I included test_interpolation.jl into runtests.jl and fixed the tests. These are now succeding because I commented the range dispatch of getinterpinds. We could also just leave it like that for now and look at the range method for getinterpinds if this is really the bottleneck for some application.

@felixcremer

Copy link
Copy Markdown
Collaborator Author

This is missing tests for the show functions for GMWOPResults and LoopWindows

@meggart

meggart commented May 19, 2026

Copy link
Copy Markdown
Owner

Yes let's leave this as it is right now. One or 2 tests for the new print methods would be great, even if only skeleton. I will look into extending the GMWOPResult show method tomorrow.

@meggart

meggart commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Ok I just pushed some tests for GMWOPResult including show methods. Ideally I would like to merge and make a release.

@felixcremer felixcremer left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@felixcremer felixcremer merged commit 9651ba7 into main Jun 2, 2026
6 of 7 checks passed
@felixcremer felixcremer deleted the fc/aggregate branch June 2, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants