Skip to content

Azure Resource Manager based deployment#160

Open
bruinbrown wants to merge 6 commits intombraceproject:masterfrom
CompositionalIT:cit/master
Open

Azure Resource Manager based deployment#160
bruinbrown wants to merge 6 commits intombraceproject:masterfrom
CompositionalIT:cit/master

Conversation

@bruinbrown
Copy link
Copy Markdown
Contributor

This PR introduces changes to the build script which bring in @isaacabraham's work on creating an Azure Resource Manager template for MBrace. Here we modify the build script to create 2 new zip files, one which has the directory structure required for an Azure webjob using the standalone worker and another which has a flat directory structure which can later be used for VM based deployments. These are included as part of the release process. We also generate a new Azure Resource Manager template per version which specifies the file source as the release.

Comment thread build.fsx
)

// Build lots of packages for differet VM sizes
let filesForZip =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format one-file-per-line so it's easier to see what's in the zip?

I suppose there's no other way to get this list of files....?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is, we could scrape the bin directory but we'd end up with assemblies which aren't really necessary like all of the Azure management libraries.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is an easier way to maintain the blacklist of the files that we don't want and subtract that from the set of all files?

Comment thread deployment/README.md Outdated
@@ -0,0 +1,48 @@
# mbrace-arm
Experimental repository containing an ARM template for deploying MBrace clusters to Azure
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment looks wrong?

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented May 2, 2017

This looks good

What's up with CI?

@bruinbrown
Copy link
Copy Markdown
Contributor Author

I've been looking into the CI issue and I can't repro it locally, I think it might be an Appveyor issue

@isaacabraham
Copy link
Copy Markdown
Contributor

How can we move forward on this? I'd very much like to get this in and start pushing out a release that supports ARM as this is a dependency on a few other things like upgrading the Starter Kit.

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Jun 5, 2017

I've been looking into the CI issue and I can't repro it locally, I think it might be an Appveyor issue

I think CI of MBrace.Azure is broken because of keys missing. We need to fix that, but it shouldn't block this

How can we move forward on this? I'd very much like to get this in and start pushing out a release that supports ARM as this is a dependency on a few other things like upgrading the Starter Kit.

@isaacabraham You are an admin and can approve. I'll review the code now too. A review from @krontogiannis or @eiriktsarpalis would be great but I think we can move ahead without

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Jun 5, 2017

I see I reviewed this previously.

  • please add a tracking bug to mbrace-docs to update the documentation, and preferably submit a PR for this too

  • please add a tracking bug to MBrace.StarterKit to update the documentation, and preferably submit a PR for this too

  • please add a note to the README outlining the manual testing steps neded (though I suppose those will be roughly the same as in deployment docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants