Skip to content

Fix partial update on simstring#15

Merged
matthewmcneely merged 1 commit into
mainfrom
matthewmcneely/fix-partial-update-on-simstring-fields
May 27, 2026
Merged

Fix partial update on simstring#15
matthewmcneely merged 1 commit into
mainfrom
matthewmcneely/fix-partial-update-on-simstring-fields

Conversation

@matthewmcneely
Copy link
Copy Markdown
Owner

@matthewmcneely matthewmcneely commented May 27, 2026

Description

This PR fixes an issue where partial updates to structs would delete shadow similarity predicates.


Summary by cubic

Fixes partial updates that accidentally deleted shadow similarity vectors for SimString fields. We now respect omitempty and keep existing vectors when the field is unset.

  • Bug Fixes
    • Skip shadow vector deletion when a SimString is empty and tagged with omitempty; only delete when explicitly cleared or below threshold.
    • Added regression test to ensure partial updates preserve the shadow vector and avoid re-embedding.

Written for commit 5cf965b. Summary will update on new commits. Review in cubic

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@matthewmcneely matthewmcneely merged commit c247dfc into main May 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant