Fix bug when setting existing key in full dict (minimal version of PR #32)#43
Merged
horkhe merged 1 commit intomailgun:masterfrom Jan 27, 2020
Merged
Conversation
Minimal version of PR mailgun#32 without adding a counter.
nicktimko
changed the title
horkhe
approved these changes
Jan 27, 2020
Member
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal version of PR #32 without adding a counter.
Line 133 in the test file would trigger the logic to unconditionally drop the oldest element at key
'a'without checking if we're going to overwrite an additional element and not actually extend the size of the dictionary.