Clean up on length call to give accurate dictionary length based on expiration#40
Open
chanchiem wants to merge 4 commits intomailgun:masterfrom
Open
Clean up on length call to give accurate dictionary length based on expiration#40chanchiem wants to merge 4 commits intomailgun:masterfrom
chanchiem wants to merge 4 commits intomailgun:masterfrom
Conversation
nadinepoppyapparel
force-pushed
the
master
branch
from
cab2131 to
cea1c3a
Compare
…esention for empty ordered dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up on length call to give accurate dictionary length based on expiration
Performance wise, it shouldn't make a big impact.
__setitem__callslen()to check for the length of the dictionary. This will also make it much more accurate; only expired items will be popped from the list.But the main motive for this push is because len(expiringdict) was inaccurate. Added unit tests.