Skip to content

Commit 0115da3

Browse files
koronchrisbra
authored andcommitted
CI: Missing test of Vim with ConPTY on Windows
Problem: Current CI Windows testing does not test Vim using ConPTY. Solution: Added a configuration to enable ConPTY to the Windows matrix. This configuration suppresses the installation of winpty, allowing testing with ConPTY. Since the fixes made at the end of last year, all tests now pass when using ConPTY, just like when using winpty. ConPTY itself is stable on recent versions of Windows, so there are no longer any reasons not to test it. closes: #19066 Signed-off-by: Muraoka Taro <koron.kaoriya@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
1 parent 5beb6b5 commit 0115da3

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,7 @@ jobs:
522522
- { features: HUGE, toolchain: mingw, VIMDLL: yes, GUI: yes, arch: x86, python3: stable, coverage: yes }
523523
- { features: HUGE, toolchain: msvc, VIMDLL: no, GUI: yes, arch: x86 }
524524
- { features: HUGE, toolchain: mingw, VIMDLL: yes, GUI: no, arch: x64, coverage: yes }
525+
- { features: HUGE, toolchain: msvc, VIMDLL: no, GUI: no, arch: x64, ttytype: conpty }
525526
- { features: NORMAL, toolchain: msvc, VIMDLL: yes, GUI: no, arch: x86 }
526527
- { features: NORMAL, toolchain: mingw, VIMDLL: no, GUI: yes, arch: x64 }
527528
- { features: TINY, toolchain: msvc, VIMDLL: yes, GUI: yes, arch: x64 }
@@ -616,11 +617,13 @@ jobs:
616617
call :downloadfile %LUA${{ env.BITS }}_URL% downloads\lua.zip
617618
7z x downloads\lua.zip -o%LUA_DIR% > nul || exit 1
618619
619-
echo %COL_GREEN%Download winpty%COL_RESET%
620-
call :downloadfile %WINPTY_URL% downloads\winpty.zip
621-
7z x -y downloads\winpty.zip -oD:\winpty > nul || exit 1
622-
copy /Y D:\winpty\%WARCH%\bin\winpty.dll src\winpty%BITS%.dll
623-
copy /Y D:\winpty\%WARCH%\bin\winpty-agent.exe src\
620+
if not "${{ matrix.ttytype }}" == "conpty" (
621+
echo %COL_GREEN%Download winpty%COL_RESET%
622+
call :downloadfile %WINPTY_URL% downloads\winpty.zip
623+
7z x -y downloads\winpty.zip -oD:\winpty > nul || exit 1
624+
copy /Y D:\winpty\%WARCH%\bin\winpty.dll src\winpty%BITS%.dll
625+
copy /Y D:\winpty\%WARCH%\bin\winpty-agent.exe src\
626+
)
624627
625628
echo %COL_GREEN%Download libsodium%COL_RESET%
626629
if "${{ matrix.toolchain }}"=="msvc" (

0 commit comments

Comments
 (0)