Make the certificate domain configurable#11
Open
DrNefarius wants to merge 1 commit into
Open
Conversation
…in auto-detection)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server certificate hardcodes
pi.holeas a SAN, which doesn't match setups that use a different local domain. This makes the domain configurable while defaulting to pi.hole, so existing installs are unaffected.What changed
Configurable certificate domain, resolved in this order:
LOCAL_HTTPS_DOMAINenv var →--domainflag (--install/--configure/--renew) → persisted state → Pi-hole'swebserver.domain(auto-detected on fresh installs) → defaultpi.hole.Interactive prompt during install/configure (pre-filled, skipped when set via env/flag or non-interactive).
Domain is persisted in state and shown in
--status, so renewals reuse it.install.shforwardsLOCAL_HTTPS_DOMAIN; README updated with a "Custom domain" section.Notes
pi.hole; installs without a saved domain fall back to it.