Fix fog bleeding into alpha values when using OneTextureBlend#17081
Merged
sfan5 merged 2 commits intoluanti-org:masterfrom Apr 10, 2026
Merged
Fix fog bleeding into alpha values when using OneTextureBlend#17081sfan5 merged 2 commits intoluanti-org:masterfrom
sfan5 merged 2 commits intoluanti-org:masterfrom
Conversation
Fixes luanti-org#17079 It is not clear how or why the bogus values appear, but the fix certainly does not hurt.
johnnyjoy
pushed a commit
to johnnyjoy/luanti-rollback-refactor
that referenced
this pull request
Apr 22, 2026
…-org#17081) fixes luanti-org#17079 It is not clear how or why the bogus values appear, but the fix certainly does not hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17079
It is not clear how or why the bogus values appear, but the fix certainly does not hurt, and at this point I don't want to invest too much time into looking into this more deeply when this works.
I tried turning the division of
float Scale = 1.0 / (uFogEnd - uFogStart);intofloat Scale = 1.0 / max(1e-6, uFogEnd - uFogStart);to avoid a potential division by zero that could explain such an issue, but that did not work.I also considered the alternative explanation that
FogColoralpha is nonsense, but that seems implausible too (it goes throughSColorwhich only allows reasonable finite values).FogEndandFogStartalso seem to be finite and reasonable.💯% written by my slightly sweaty hands.
Ready for Review. See the issue for testing instructions.