Fix node placement animation desync#17001
Merged
sfan5 merged 1 commit intoluanti-org:masterfrom Apr 10, 2026
Merged
Conversation
cx384
approved these changes
Mar 19, 2026
Member
cx384
left a comment
There was a problem hiding this comment.
Tested, works.
With this the place animation resets on every right click, or when holding it on every "repeat_place_time".
And a sound plays on every placed node.
(In the current version, the full place animation plays every time and the next place sound does not play before the end of the animation. The fix feels unnatural, maybe I'm too used to this bug, but it's an improvement, I think.)
johnnyjoy
pushed a commit
to johnnyjoy/luanti-rollback-refactor
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compact, short information about your PR for easier understanding:
Fix node placement desync.
Resets the placement animation.
Not sure.
Not sure.
Engine quality upgrade.
None used.
This PR is Ready for Review.
How to test
Place some nodes really fast.