Skip to content

Fix node placement animation desync#17001

Merged
sfan5 merged 1 commit intoluanti-org:masterfrom
jordan4ibanez:placement_noise_fix
Apr 10, 2026
Merged

Fix node placement animation desync#17001
sfan5 merged 1 commit intoluanti-org:masterfrom
jordan4ibanez:placement_noise_fix

Conversation

@jordan4ibanez
Copy link
Copy Markdown
Contributor

@jordan4ibanez jordan4ibanez commented Mar 7, 2026

Add compact, short information about your PR for easier understanding:

  • Goal of the PR
    Fix node placement desync.
  • How does the PR work?
    Resets the placement animation.
  • Does it resolve any reported issue?
    Not sure.
  • Does this relate to a goal in the roadmap?
    Not sure.
  • If not a bug fix, why is this PR needed? What usecases does it solve?
    Engine quality upgrade.
  • If you have used an LLM/AI to help with code or assets, you must disclose this.
    None used.

This PR is Ready for Review.

How to test

Place some nodes really fast.

@sfan5 sfan5 changed the title Fix node placement desync Fix node placement animation desync Mar 7, 2026
Copy link
Copy Markdown
Member

@cx384 cx384 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works.
With this the place animation resets on every right click, or when holding it on every "repeat_place_time".
And a sound plays on every placed node.

(In the current version, the full place animation plays every time and the next place sound does not play before the end of the animation. The fix feels unnatural, maybe I'm too used to this bug, but it's an improvement, I think.)

@sfan5 sfan5 merged commit 9b4e59c into luanti-org:master Apr 10, 2026
19 checks passed
@jordan4ibanez jordan4ibanez deleted the placement_noise_fix branch April 21, 2026 23:25
johnnyjoy pushed a commit to johnnyjoy/luanti-rollback-refactor that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants