Refactor and use Cholesky decomposition for correlated_values and correlated_values_norm#271
Open
jagerber48 wants to merge 7 commits intolmfit:masterfrom
Open
Refactor and use Cholesky decomposition for correlated_values and correlated_values_norm#271jagerber48 wants to merge 7 commits intolmfit:masterfrom
correlated_values and correlated_values_norm#271jagerber48 wants to merge 7 commits intolmfit:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 96.50% 96.56% +0.05%
==========================================
Files 16 16
Lines 1919 1951 +32
==========================================
+ Hits 1852 1884 +32
Misses 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This PR is ready for review. |
Contributor
Author
|
While this PR is ready for review, it's going to conflict badly with #262. Let's hold off on this one until after that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-fileswith no errorsClean up
correlated_valuesandcorrelated_values_norm. Make the code easier to follow. Also use the more efficient Cholesky decomposition in cases where the user-provided covariance matrix is positive-definite. If it is strictly positive semi-definite then use the eigenvalue decomposition that was previously used.Note, previously
correlated_values_norm(which accepts a normalized correlation matrix) did the numerical lifting andcorrelated_values(which accepts a covariance matrix) calledcorrelated_values_norm. This is reversed now. Nowcorrelated_valuesdoes the numerical work andcorrelated_values_normcallscorrelated_values.