Removing unumpy.py core dependency on matrices #120
Open
AdityaSavara wants to merge 3 commits intolmfit:masterfrom
Open
Removing unumpy.py core dependency on matrices #120AdityaSavara wants to merge 3 commits intolmfit:masterfrom
AdityaSavara wants to merge 3 commits intolmfit:masterfrom
Conversation
Changed "asmatrix" to "asarray" Changed * to @ Passed unit tests on my computer except for the lib2to3 unit test since I do not have that module.
The transpose() function was used to replace .H, but that only works for real numbers. So a .conj() call has been placed prior to the transpose call.
Of course these edits do not need to be accepted. However, old comments were deprecated.
Contributor
Author
|
I am not sure if the integration checks are failing because I used the @ operator or due to something else. Would it be better to use numpy.matmul? |
Contributor
Probably not, the errors in the logs seem to not be related to your changes. I guess those errors affect not only this pull request. I think my pr (#116) fixes some of the bugs because they annoyed me a lot... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing numpy deprecation warning mentioned here #114
Changed "asmatrix" to "asarray"
Changed * operator to @ operator for the inverse functions (as shown in diff file below).
Passed unit tests on my computer except for the lib2to3 unit test since I do not have that module.
This also removed the deprecation warnings during unit tests on my code, without breaking my own code's unit tests.
Adding .conj() for non-real numbers.
I don't have a unit test to check correct the behavior for non-real numbers.