Conversation
🦋 Changeset detectedLatest commit: f4d080f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
| message TdServerMessage { | ||
| oneof message { | ||
| TdSessionCreated session_created = 1; | ||
| TdInferenceStarted inference_started = 2; | ||
| TdInferenceStopped inference_stopped = 3; | ||
| TdEouPrediction eou_prediction = 4; | ||
| TdSessionClosed session_closed = 5; | ||
| TdError error = 6; | ||
| } | ||
| optional string request_id = 7; | ||
| google.protobuf.Timestamp server_created_at = 8; | ||
| optional google.protobuf.Timestamp client_created_at = 9; | ||
| } |
There was a problem hiding this comment.
Should we split this into a Request/Response message?
There was a problem hiding this comment.
For the RemoteSession, I have Request/Response and events
https://github.com/livekit/protocol/blob/main/protobufs/agent/livekit_agent_session.proto
There was a problem hiding this comment.
I guess it depends on how you look at them: e.g. TdInferenceStart and TdInferenceStarted is a Request-and-Response pair, we just wrap all the requests and responses in TdClientMessage and TdServerMessage.
davidzhao
left a comment
There was a problem hiding this comment.
is this only for the turn detector? or more designed to be the generic websocket protocol?
They are only for the turn detector. Barge-in or STT have somewhat different control messages or different formats: Bargein (ws binary+json): in: audio frame (pcm), inference start/end, out: prediction Do you think we should try to unify them? |
Add protobuf messages for both client <-> Inference and Inference <-> GPU host.