Add agent customization: agents, hooks, skills, and instructions#1502
Merged
Conversation
Owner
liudger
commented
Jun 2, 2026
liudger
commented
- Add security-reviewer agent definition
- Add run-validation-after-edits hook (config + script)
- Add feature-doc-updates skill; expand bsblan-testing skill
- Restructure AGENTS.md and slim copilot-instructions.md
- Point CLAUDE.md at AGENTS.md
- Update code-review prompt
- Add security-reviewer agent definition - Add run-validation-after-edits hook (config + script) - Add feature-doc-updates skill; expand bsblan-testing skill - Restructure AGENTS.md and slim copilot-instructions.md - Point CLAUDE.md at AGENTS.md - Update code-review prompt
liudger
added
security
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 6 6
Lines 1087 1087
Branches 146 146
=======================================
Hits 1086 1086
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces repository-level AI agent customization for python-bsblan, including canonical agent instructions, additional skills, a security reviewer agent, a post-edit validation hook, and updated review prompt/docs pointers.
Changes:
- Add
AGENTS.mdas the canonical agent guidance and updateCLAUDE.md+.github/copilot-instructions.mdto reference it. - Add a security-focused agent definition and a new “feature-doc-updates” skill; expand the existing testing skill.
- Add a post-tool-use hook to automatically run tests + prek after edits, and refresh the code-review prompt.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
CLAUDE.md |
Points Claude instructions to AGENTS.md. |
AGENTS.md |
Adds canonical repo agent instructions, validation commands, and conventions. |
.github/copilot-instructions.md |
Slimmed to a compatibility pointer to AGENTS.md. |
.github/agents/security-reviewer.agent.md |
Adds a dedicated security review agent definition. |
.github/hooks/run-validation-after-edits.json |
Registers a PostToolUse hook to run validation after edits. |
.github/hooks/run_validation_after_edits.sh |
Implements the hook logic (detect edits, run pytest + prek). |
.github/prompts/code-review.prompt.md |
Updates the code review prompt to prioritize findings and quality gates. |
.github/skills/feature-doc-updates/SKILL.md |
Adds a skill to drive doc updates alongside feature work. |
.github/skills/bsblan-testing/SKILL.md |
Updates fixture-loading guidance and expands testing/mocking guidance. |
Comment on lines
+16
to
+21
| Setup commands: | ||
|
|
||
| ```bash | ||
| npm install | ||
| make setup | ||
| ``` |
Comment on lines
+140
to
+142
| ### Fixture Setup and Registration | ||
|
|
||
| Define shared fixtures in `tests/conftest.py` so pytest auto-discovers them. |
Comment on lines
+48
to
+49
| - [ ] Error handling uses custom exceptions (`BSBLANError`, | ||
| `BSBLANConnectionError`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.