Skip to content

chore: update version to 6.0.33#150

Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom
wyu71:master
Apr 29, 2026
Merged

chore: update version to 6.0.33#150
lzwind merged 1 commit intolinuxdeepin:masterfrom
wyu71:master

Conversation

@wyu71
Copy link
Copy Markdown
Contributor

@wyu71 wyu71 commented Apr 29, 2026

  • bump version to 6.0.33

Log : bump version to 6.0.33

Summary by Sourcery

Chores:

  • Update Debian changelog entry for version 6.0.33.

- bump version to 6.0.33

Log : bump version to 6.0.33
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 29, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian package metadata to reflect the new project version 6.0.33.

File-Level Changes

Change Details Files
Update Debian changelog to bump package version to 6.0.33.
  • Increment the package version number from the previous release to 6.0.33 in the changelog header.
  • Adjust associated changelog entry text to note the 6.0.33 bump, keeping existing formatting and structure.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 6.0.33
EXISTED: no
DISTRIBUTION: unstable

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

这段代码是 Debian 软件包的变更日志文件(debian/changelog),主要用于记录软件包的版本更新历史。以下是对该 diff 的详细审查和改进意见:

1. 语法与格式审查

现状:
该 diff 符合 Debian changelog 的标准格式(定义在 deb-changedch 工具中)。

  • 版本号格式正确:package (version) distribution urgency
  • 维护者信息格式正确:-- Maintainer Name <email> date
  • 日期格式符合 RFC 5322 标准:Wed, 29 Apr 2026 16:32:15 +0800

潜在问题:

  • 时间戳异常:日期显示为 2026 年。除非这是为了未来某个特定时刻的自动发布而准备的,否则这极有可能是系统时间错误笔误。在版本控制中,未来的提交时间可能会导致构建系统(如 dpkg-buildpackage)产生警告或混淆。

2. 代码质量与逻辑审查

现状:

  • 变更描述fix(keyboard): resolve layout name disappearing after deletion
    • 使用了 scope: description 的格式,这是一种良好的变更日志实践(常见于 Conventional Commits),有助于快速定位修改的模块。
    • 描述清晰,准确说明了修复的问题(删除后布局名称消失)和影响范围(键盘)。

改进意见:

  • 一致性:对比下方的 6.0.32 版本日志 fix: sync keyboard layout...,新日志引入了 fix(keyboard) 的前缀。建议在整个项目中保持风格统一。如果项目决定采用 Conventional Commits 风格,建议检查之前的日志是否需要补全 scope,或者统一去掉 scope 以保持简洁。
  • 详细程度:虽然当前描述已经足够清晰,但如果该修复涉及复杂的逻辑或特定的 Bug ID,建议在日志中补充引用。例如:
    * fix(keyboard): resolve layout name disappearing after deletion (Closes: #12345)
    
    或者如果有对应的 Issue 链接,也可以附上。

3. 代码安全审查

现状:
Changelog 本身是元数据,不包含可执行代码,因此不直接涉及代码执行层面的安全漏洞(如缓冲区溢出、SQL注入等)。

改进意见:

  • 隐私与敏感信息:检查维护者邮箱 wangyu@uniontech.com 是否为适合公开的办公邮箱。通常这是没问题的,但需确保没有误填个人隐私邮箱。
  • 版本号欺骗:确保版本号的递增是合理的。从 6.0.32 升级到 6.0.33 符合语义化版本控制或 Debian 版本控制习惯。随意修改版本号可能导致包管理器无法正确判断更新优先级。

4. 综合改进建议

基于上述分析,建议对内容进行如下微调(主要是修正时间):

+deepin-fcitx5configtool-plugin (6.0.33) unstable; urgency=medium
+
+  * fix(keyboard): resolve layout name disappearing after deletion
+
+ -- Wang Yu <wangyu@uniontech.com>  Wed, 29 Apr 2026 16:32:15 +0800

修改建议:
请将日期 2026 修改为当前正确的年份(例如 20242025),除非确实是在规划未来的版本。

修正后的示例:

+deepin-fcitx5configtool-plugin (6.0.33) unstable; urgency=medium
+
+  * fix(keyboard): resolve layout name disappearing after deletion
+
+ -- Wang Yu <wangyu@uniontech.com>  Wed, 29 Apr 2024 16:32:15 +0800
+
 deepin-fcitx5configtool-plugin (6.0.32) unstable; urgency=medium

总结:
该 diff 在格式和描述上质量较高,主要问题在于时间戳年份异常。修正时间后即可合并。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit f376ee5 into linuxdeepin:master Apr 29, 2026
14 of 15 checks passed
@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 29, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.33
  • Tag SHA: 3b1508c8016da08977b121b2c6c2e9a5511c605e
  • Commit SHA: 93d7f266af12dd7759ef73af98557d2a6a1764da
  • Tag Message:
    Release deepin-fcitx5configtool-plugin 6.0.33
    
    
  • Tagger:
    • Name: wyu71
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants