fix(addonUi): simplify DetailAddonsItem structure by removing Loader …

[dengzhongyuan365-dev]

…component

Removed the Loader component from DetailAddonsItem.qml, directly integrating DccRepeater for improved performance and clarity in the UI structure.

bug: https://pms.uniontech.com/bug-view-355273.html

Summary by Sourcery

Bug Fixes:

• Remove unnecessary lazy loading around the addons list to improve responsiveness and address layout/performance issues in the detail view.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the Loader-wrapped DccRepeater in DetailAddonsItem.qml with a directly embedded DccRepeater, simplifying the QML structure and removing asynchronous loading for addon items.

Sequence diagram for direct DccRepeater usage in DetailAddonsItem

sequenceDiagram
participant DetailAddonsItem
participant DccRepeater
participant GlobalAddonsModel
participant AddonDelegate

DetailAddonsItem->>DetailAddonsItem: loading = false
DetailAddonsItem->>DccRepeater: create with model = globalAddons
DccRepeater->>GlobalAddonsModel: read addon items
loop for each addon
  DccRepeater->>AddonDelegate: instantiate delegate DccObject
  AddonDelegate->>AddonDelegate: expanded = true
end

Loading

Class diagram for updated DetailAddonsItem QML structure

classDiagram
class DetailAddonsItem {
  bool loading
}

class DccRepeater {
  model globalAddons
}

class AddonDelegate {
  bool expanded
}

DetailAddonsItem *-- DccRepeater : contains
DccRepeater *-- AddonDelegate : delegate

Loading

File-Level Changes

Change	Details	Files
Simplified DetailAddonsItem QML by inlining DccRepeater and removing the Loader indirection and asynchronous loading.	Removed the Loader wrapper that previously controlled activation and asynchronous loading based on the loading flag Embedded DccRepeater directly in the component hierarchy where Loader.sourceComponent was used Preserved the existing model, delegate, and layout logic within DccRepeater while removing no-longer-needed Loader properties	src/dcc-fcitx5configtool/qml/DetailAddonsItem.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Now that the Loader has been removed, the loading property and Component.onCompleted: loading = false appear unused and can likely be cleaned up or repurposed to avoid dead state.
• Previously the Loader’s active: !loading and asynchronous: true deferred and decoupled creation of the repeater; consider whether you still need a guard or deferred initialization around globalAddons to avoid creating delegates before the model is ready.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Now that the Loader has been removed, the `loading` property and `Component.onCompleted: loading = false` appear unused and can likely be cleaned up or repurposed to avoid dead state.
- Previously the Loader’s `active: !loading` and `asynchronous: true` deferred and decoupled creation of the repeater; consider whether you still need a guard or deferred initialization around `globalAddons` to avoid creating delegates before the model is ready.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dengzhongyuan365-dev]

/merge

[deepin-bot]

This pr cannot be merged! (status: unknown)