Skip to content

fix: remove redundant signal handler setup in fcitx5helper#126

Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom
wyu71:master
Jan 5, 2026
Merged

fix: remove redundant signal handler setup in fcitx5helper#126
lzwind merged 1 commit intolinuxdeepin:masterfrom
wyu71:master

Conversation

@wyu71
Copy link
Copy Markdown
Contributor

@wyu71 wyu71 commented Jan 5, 2026

  • Removed duplicate setupSignalHandler() call and debug log.

Log: remove redundant signal handler setup in fcitx5helper
pms: BUG-339241

Summary by Sourcery

Bug Fixes:

  • Eliminate duplicate setupSignalHandler() invocation and its associated debug log in fcitx5helper to avoid redundant signal handler setup.

- Removed duplicate setupSignalHandler() call and debug log.

Log: remove redundant signal handler setup in fcitx5helper
pms: BUG-339241
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 5, 2026

TAG Bot

TAG: 6.0.24
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jan 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes a redundant signal handler setup call and its associated debug logging from fcitx5helper, cleaning up duplicate initialization logic and updating the Debian changelog accordingly.

File-Level Changes

Change Details Files
Remove redundant signal handler setup invocation and log from fcitx5helper main routine.
  • Delete extra qCDebug log message indicating signal handler setup.
  • Remove duplicate setupSignalHandler() call that was executed after the QCoreApplication::aboutToQuit connection.
  • Rely on the remaining signal handler initialization elsewhere in the startup path to avoid double registration.
src/fcitx5helper/main.cpp
Update Debian packaging changelog to document the bug fix.
  • Add an entry referencing BUG-339241 describing removal of redundant signal handler setup.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lzwind lzwind merged commit e71484f into linuxdeepin:master Jan 5, 2026
8 checks passed
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants