Skip to content

Unify DDL execution and dry-run into shared processCreate methods #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jogrogan merged 2 commits into from
Apr 15, 2026
Merged

Unify DDL execution and dry-run into shared processCreate methods #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
650f764
refactor: unify DDL execution and dry-run into shared processCreate* …
jogrogan Apr 10, 2026
87e108c
Increase coverage for modified files
jogrogan Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 1 addition & 46 deletions hoptimator-cli/src/main/java/sqlline/HoptimatorAppConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package sqlline;

import com.linkedin.hoptimator.Pipeline;
import com.linkedin.hoptimator.Source;
import com.linkedin.hoptimator.SqlDialect;
import com.linkedin.hoptimator.jdbc.HoptimatorConnection;
import com.linkedin.hoptimator.jdbc.HoptimatorDdlUtils;
Expand Down Expand Up @@ -278,56 +276,13 @@ public void execute(String line, DispatchCallback dispatchCallback) {
}
String sql = split[1];
HoptimatorConnection conn = (HoptimatorConnection) sqlline.getConnection();
Pair<SchemaPlus, Table> schemaSnapshot = null;
String viewName = "sink";
try {
String querySql = sql;
SqlCreateMaterializedView create = null;
SqlNode sqlNode = HoptimatorDriver.parseQuery(conn, sql);
if (sqlNode.getKind().belongsTo(SqlKind.DDL)) {
if (sqlNode instanceof SqlCreateMaterializedView) {
create = (SqlCreateMaterializedView) sqlNode;
final SqlNode q = HoptimatorDdlUtils.renameColumns(create.columnList, create.query);
querySql = q.toSqlString(CalciteSqlDialect.DEFAULT).getSql();
viewName = HoptimatorDdlUtils.viewName(create.name);
} else {
sqlline.error("Unsupported DDL statement: " + sql);
dispatchCallback.setToFailure();
return;
}
}

RelRoot root = HoptimatorDriver.convert(conn, querySql).root;
Properties connectionProperties = conn.connectionProperties();
RelOptTable table = root.rel.getTable();
if (table != null) {
connectionProperties.setProperty(DeploymentService.PIPELINE_OPTION, String.join(".", table.getQualifiedName()));
} else if (create != null) {
connectionProperties.setProperty(DeploymentService.PIPELINE_OPTION, create.name.toString());
}
PipelineRel.Implementor plan = DeploymentService.plan(root, conn.materializations(), connectionProperties);
if (create != null) {
schemaSnapshot = HoptimatorDdlUtils.snapshotAndSetSinkSchema(conn.createPrepareContext(),
new HoptimatorDriver.Prepare(conn), plan, create, querySql);
}
Pipeline pipeline = plan.pipeline(viewName, conn);
List<String> specs = new ArrayList<>();
for (Source source : pipeline.sources()) {
specs.addAll(DeploymentService.specify(source, conn));
}
specs.addAll(DeploymentService.specify(pipeline.sink(), conn));
specs.addAll(DeploymentService.specify(pipeline.job(), conn));
List<String> specs = HoptimatorDdlUtils.specifyFromSql(sql, conn).specs;
specs.forEach(x -> sqlline.output(x + "\n\n---\n\n"));
} catch (SQLException e) {
sqlline.error(e);
dispatchCallback.setToFailure();
}
if (schemaSnapshot != null) {
if (schemaSnapshot.right != null) {
schemaSnapshot.left.add(viewName, schemaSnapshot.right);
}
schemaSnapshot.left.removeTable(viewName);
}
}

@Override
Expand Down
Loading
Loading