Route admins from notification "view more" into submission review mode

[rtibblesbot]

Summary

Admins clicking "view more" on a Community Library submission notification landed on the read-only details panel because SubmissionDetailsModal gated the Review button and side panel on an adminReview prop hardcoded to false on the channelList route.

The fix: remove the adminReview prop entirely and gate the review UI directly on store.getters.isAdmin inside SubmissionDetailsModal/index.vue. One component change — no router changes, no notification handler changes.

What changed:

• SubmissionDetailsModal/index.vue — removed adminReview prop; added const isAdmin = computed(() => store.getters.isAdmin); replaced v-if="adminReview" with v-if="isAdmin" on Review button, Actions dropdown, and ReviewSubmissionSidePanel; selects AdminCommunityLibrarySubmission vs CommunityLibrarySubmission based on isAdmin
• SubmissionDetailsModal/__tests__/index.spec.js — new test file asserting that admin users see the Review button and side panel while non-admin users do not
• administration/router.js — simplified route props from a function passing adminReview: true to props: true (the prop is now removed from the component)

Screenshots

Admin view — Review button visible on PENDING submission:

Admin view — ReviewSubmissionSidePanel open after clicking Review:

References

Closes #5994

Reviewer guidance

Manual verification:

1. Log in as an admin user
2. Navigate to any Community Library submission URL (/channels/#/community-library/:channelId/:submissionId)
3. Expected: "REVIEW" button and "ACTIONS" dropdown visible; clicking "REVIEW" opens ReviewSubmissionSidePanel
4. Repeat as a non-admin — expected: read-only panel, no Review or Actions buttons

AI usage

Used Claude Code to implement the change following reviewer guidance. Captured live screenshots by driving the running dev server with Playwright.

---

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

---

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

• Ran pre-flight CI checks (lint, format, tests) and verified all pass
• Rebased onto the target branch and resolved any conflicts
• Reorganized commit history into clean, logical commits
• Audited the diff to ensure only issue-relevant files are changed
• Built PR body from the repository's PR template with evidence blocks

[rtibbles]

Screenshots: The dev server returned 500 for all pages during PR creation. Manual verification per the steps above is required.

Yes, it is required - I think the devserver should now run properly for you, so please retry!

[rtibblesbot]

Admin arriving via notification "view more" (?openReview=true) — review side panel opens automatically:

---

Same route without ?openReview=true — REVIEW button present but panel not auto-opened:

adminReview is driven by isAdmin. Non-admin users see the read-only view (no REVIEW button, no panel).

[rtibbles]

Sorry - this can be a much simpler fix. I have amended the issue which added the superfluous "open the review panel automatically" behaviour.

Instead, we can just remove the adminReview prop from the SubmissionDetailsModal/index.vue - remove the one place it is used currently. And instead just gate showing the review button on isAdmin from the core getters.

That means we can clean up almost all of these additions and trim it back to one very small targeted change in this one component (and removing the now superfluous prop from any of its call sites).

Please update and then update screenshots IN THE PR BODY, not as a comment.

[rtibblesbot]

Done — simplified as requested. The PR now makes a single targeted change: removed the adminReview prop from SubmissionDetailsModal entirely and replaced all uses with computed(() => store.getters.isAdmin) inside the component. This means the component determines admin status itself from the store rather than relying on props passed from routers.

Rolled back:

• channelList/router.js → reverted to props: true
• administration/router.js → reverted to props: true
• NotificationList.vue → reverted goToSubmissionDetails to plain URL redirect (no ?openReview=true)

Also removed the router and notification list tests (no longer relevant), and updated the SubmissionDetailsModal test to verify admin/non-admin resource selection via the store getter.

Please update screenshots in the PR body once you've done manual verification.

[rtibblesbot]

Removed the adminReview prop from SubmissionDetailsModal/index.vue. The Review button, Actions dropdown, and ReviewSubmissionSidePanel now gate on computed(() => store.getters.isAdmin) directly. All the router, notification handler, and query-param additions are reverted.

Screenshots are in the PR body.

[rtibbles]

I appreciate the enthusiasm - but the screenshots should not be committed.

Please remove from the commit history, and simplify this down to a single commit.