feat: /assign self-assignment for good first issue (#62)

[rtibblesbot]

Summary

Implements the /assign self-assignment mechanism for good first issue issues, as agreed in #47.

Contributors can comment /assign on issues labeled help wanted + good first issue to self-assign, subject to a 2-issue cross-repo limit and 7-day cooldown on recently dropped issues. The bot posts a guidance comment when the good first issue label is applied, and keyword-based assignment requests on GFI issues now include /assign guidance.

All /assign Slack notifications route to #support-dev-notifications only.

References

• Closes Implement /assign self-assignment for good first issue issues #62
• Related: Proposal: Auto-assign contributors to help wanted issues via /assign command #47

Reviewer guidance

Manual testing is done in test-actions. Temporarily update reusable workflow references to point to this branch.

Key test scenarios:

• Comment /assign on an unassigned help wanted + good first issue issue → bot assigns and confirms
• Comment /assign when at the 2-issue limit → bot declines with assignment list and cooldown info
• Add good first issue label to a help wanted issue → bot posts guidance comment
• Comment "can I work on this" on a GFI issue → bot replies with /assign guidance

Risky areas:

• Cross-repo limit checking via search API + timeline events (scripts/utils.js:getRecentUnassignments) — depends on GitHub search indexing latency and timeline event format
• Unassignment deduplication logic (scripts/utils.js ~line 320) — ensures multiple assign/unassign cycles on the same issue count as one slot
• /assign decision tree in handleAssignCommand (scripts/contributor-issue-comment.js) — many branches with specific Slack routing per path

AI usage

Built entirely by Claude Code following a detailed implementation plan (see PLAN/index.md). Each task was implemented incrementally and code was reviewed for correctness after each step. Test infrastructure was removed per reviewer feedback (no unit tests needed for this codebase).

---

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

• Ran pre-flight CI checks (lint, format, tests) and verified all pass
• Rebased onto the target branch and resolved any conflicts
• Reorganized commit history into clean, logical commits
• Audited the diff to ensure only issue-relevant files are changed
• Built PR body from the repository's PR template with evidence blocks

[rtibblesbot]

Rebased onto main to resolve merge conflicts (yarn.lock had a conflict on the axios entry due to a version bump on main; resolved by taking the upstream version 1.13.6). All 36 tests still pass.

[MisRob]

This PR shouldn't affect unrelated files

[rtibblesbot]

Restored - this was deleted accidentally.

[rtibblesbot]

I was unable to complete this task after multiple attempts. Manual review and intervention may be needed.

[rtibblesbot]

I was unable to complete this task after multiple attempts. Manual review and intervention may be needed.

[rtibblesbot]

I was unable to complete this task after multiple attempts. Manual review and intervention may be needed.

[rtibblesbot]

I was unable to complete this task after multiple attempts. Manual review and intervention may be needed.

[rtibblesbot]

I was unable to complete this task after multiple attempts. Manual review and intervention may be needed.

[MisRob]

There is no need to test constants. The file can be removed.

[rtibblesbot]

Removed.

[MisRob]

Suggested change

	const COOLDOWN_DAYS = 7;
	const ASSIGN_COOLDOWN_DAYS = 7;

[rtibblesbot]

Renamed to ASSIGN_COOLDOWN_DAYS throughout.

[MisRob]

It'd be better to remove all these new 'Any' table entries and organize the new information to the original table structure - that is utilizing Core team, Close contributor, Issue creator, and Other categories, and none other. This will improve understanding the information a lot.

Furthermore let's use the following language for describing comment type

• /assign command
• assign keyword (links to https://github.com/learningequality/.github/blob/main/scripts/constants.js#L44)
• regular

Finally, let's not use shortcuts, such as GFI - it's not immediately clear to what it refers to.

[rtibblesbot]

Restructured: removed Any** rows, integrated /assign command rows under Close contributor/Issue creator/Other contributor types, updated comment type terminology (regular/assign keyword//assign command), and replaced GFI with good first issue throughout.

[rtibblesbot]

Two items missed in the previous pass: split the combined 'Close contributor, Issue creator, Other' rows into separate rows per contributor type (18 rows total — 6 per category), and linked 'assign keyword' to constants.js#L44 throughout the table.

[MisRob]

@rtibblesbot we decided not to implement tests for affected GitHub workflows. So all test files, including test setup and changes to package.json and yarn.lock can be removed.

[rtibblesbot]

Done. Removed all test files (contributor-issue-comment.test.js, good-first-issue-comment.test.js, utils.test.js, test-helpers.js), removed jest from package.json, and updated yarn.lock.

[MisRob]

There should be no updates to yarn.lock in this PR. Let's revert completely

[rtibblesbot]

Reverted. yarn.lock now matches main exactly.

[MisRob]

Can be removed

[rtibblesbot]

Removed.

[rtibbles]

Local review against #62 ACs. CI green; no UI files. Findings inline.

Comment on a line not in the diff:

scripts/manage-issue-header.js:62 — suggestion: When help wanted is removed, the header flips to "not open" but the /assign guidance comment stays, inviting /assign that returns BOT_MESSAGE_ISSUE_NOT_OPEN. Add deleteBotComments(issueNumber, LE_BOT_USERNAME, ASSIGN_GUIDANCE_MARKER, { github, context, core }) in the unlabeled branch (needs a utils/constants import).

[rtibbles]

blocking: This fires only on the good first issue labeled event, and good-first-issue-comment.js:27 requires help wanted already present. Tagging GFI before help wanted is valid — a good first issue not yet open. The normal prepare-then-open flow adds help wanted second, so nothing re-runs this check and guidance never posts on issues that just opened. Also trigger on the help wanted labeled event and require both labels in the script before posting; a lone GFI stays silent.

[rtibblesbot]

Fixed in 4422dc8. Now triggers on both good first issue labeled and help wanted labeled events. good-first-issue-comment.js already checks for both labels before posting, so a lone GFI label stays silent — guidance only posts when both are present.

[rtibbles]

suggestion: search.issuesAndPullRequests({ q }) returns only the first 30 results, so an active contributor's unassignments can be missed and the cooldown under-counts. Use github.paginate(github.rest.search.issuesAndPullRequests, { q, per_page: 100 }) and iterate the result directly (drop data.items).

[rtibblesbot]

Fixed in 4422dc8. Changed to github.paginate(github.rest.search.issuesAndPullRequests, { q, per_page: 100 }) and iterate the result directly (no data.items).

[rtibbles]

suggestion: Exact match drops /assign me, which falls through to keyword detection instead of assigning. /\/assign\b/i.test(commentBody) accepts /assign me and please /assign while rejecting /assignee.

[rtibblesbot]

Implemented in 4422dc8. Changed to /\/assign\b/i.test(commentBody) — accepts /assign me and please /assign while rejecting /assignee. The plan had exact-match but the regex is clearly better UX.

[rtibbles]

suggestion: Unrelated trailing-newline strip (accidental reformat in 0d2508a). Revert: git checkout main -- .github/FUNDING.yml.

[rtibblesbot]

No change needed — git diff main -- .github/FUNDING.yml shows no diff. The file already matches main (trailing newline is present).

[rtibbles]

praise: Dedup-by-issue keeping the latest unassignment cleanly handles multiple assign/unassign cycles on one issue.

[rtibblesbot]

Glad that reads clearly.

[rtibbles]

praise: Filtering cooldown entries against currently-assigned issues prevents double-counting a reassigned issue — correct slot math.

[rtibblesbot]

Glad that reads clearly.

[rtibblesbot]

Implemented the manage-issue-header.js suggestion in 4422dc8: added deleteBotComments in the unlabeled branch to remove the /assign guidance comment when help wanted is stripped.