allow image references combining a tag and a digest#4579
Open
pddg wants to merge 1 commit into
Open
Conversation
pddg
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
dosubot
Bot
added
size:M
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates function image reference validation to use the upstream OCI/Docker reference parser and expands test coverage for tag+digest combinations.
Changes:
- Replace custom regex-based image reference validation with
github.com/distribution/reference. - Update validation documentation to describe the accepted reference grammar (tag, digest, or both).
- Add tests covering tag+digest references and an invalid
name@taginput.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/api/kptfile/v1/validation.go | Switches validation to distribution/reference.Parse and updates doc comment accordingly. |
| pkg/api/kptfile/v1/validation_test.go | Adds test cases for tag+digest references and an invalid @v0.1.0 reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if !matched { | ||
| return fmt.Errorf("function name %q is invalid", name) | ||
| if _, err := reference.Parse(name); err != nil { | ||
| return fmt.Errorf("function name %q is invalid: %w", name, err) |
Signed-off-by: Shoma Kokuryo <s.kokuryo@gmail.com>
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
The failing test passes without any issues in my environment. It does not seem to be related to the changes in this PR. Is the test itself flaky? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #4578
Motivation
The
name:tag@digestform is valid per the OCI/Docker reference grammar.