Skip to content

Refactor docs folder#4571

Merged
efiacor merged 13 commits into
kptdev:mainfrom
nokia:refactor-docs
Jun 11, 2026
Merged

Refactor docs folder#4571
efiacor merged 13 commits into
kptdev:mainfrom
nokia:refactor-docs

Conversation

@CsatariGergely

Copy link
Copy Markdown
Contributor

The content of the docs folder is not documentation, therefore it was refactored

  • Docs style guide moved to the README.md of the documentation and was extended with the Nephio documentation guide what is followed by the Porch documentation
  • ROADMAP.md was removed as it was outdated and we follow the roadmap in a GitHub Project now
  • The folder was renamed to architecture

The content of the docs folder is not documentation, therefore it was refactored

- Docs style guide moved to the README.md of the documentation and was extended with
  the Nephio documentation guide what is followed by the Porch documentation
- ROADMAP.md was removed as it was outdated and we follow the roadmap in a GitHub Project now
- The folder was renamed to `architecture`

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copilot AI review requested due to automatic review settings June 4, 2026 07:08
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 4, 2026
@netlify

netlify Bot commented Jun 4, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 1a2bcd7
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a2a936995b17100082721e8
😎 Deploy Preview https://deploy-preview-4571--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@CsatariGergely

Copy link
Copy Markdown
Contributor Author

I'm not sure if we should keep the design-docs folder. It contains KEP kind of documents, but at the moment we do not follow any process like the KEP and I do not know what is the status of these feature ideas as there are no Issues linked to the documents.

@CsatariGergely CsatariGergely linked an issue Jun 4, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the repository’s former docs/ content by relocating non-site documentation into a new architecture/ tree, consolidating documentation writing guidance into the documentation site README, and replacing the removed roadmap document with a GitHub Project link.

Changes:

  • Replace the root README roadmap link (previously docs/ROADMAP.md) with a GitHub Project link.
  • Move/expand the documentation style guide into documentation/README.md.
  • Remove outdated docs/ROADMAP.md and relocate design/style-guide content under architecture/.

Reviewed changes

Copilot reviewed 4 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
README.md Updates roadmap guidance to point to a GitHub Project instead of a removed file.
documentation/README.md Adds an expanded documentation style guide to the docs site README.
docs/style-guides/docs.md Removes the old standalone documentation style guide file.
docs/ROADMAP.md Removes the outdated roadmap document.
architecture/sync/prototype-controller.md Adds architecture notes/prototype instructions for RemoteRootSync controller.
architecture/style-guides/errors.md Adds an error message style guide under the new architecture hierarchy.
architecture/design-docs/00-template.md Adds a design doc template under architecture/design-docs.
architecture/design-docs/01-live-invenstory-to-rg.md Adds a design doc about inventory/resourcegroup changes (now under architecture).
architecture/design-docs/02-oci-support.md Adds an OCI support design doc (now under architecture).
architecture/design-docs/03-pipeline-merge.md Adds a pipeline merge design doc (now under architecture).
architecture/design-docs/04-arm-build.md Adds an ARM build design doc (now under architecture).
architecture/design-docs/05-kpt-fn-exclude.md Adds a function-exclude design doc (now under architecture).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread documentation/README.md Outdated
Comment thread documentation/README.md Outdated
Comment thread documentation/README.md Outdated
Comment thread README.md Outdated
Comment thread documentation/README.md Outdated
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 4, 2026 11:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 12 changed files in this pull request and generated 2 comments.

Comment thread documentation/README.md Outdated
Comment thread documentation/README.md Outdated
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copilot AI review requested due to automatic review settings June 4, 2026 12:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 14 changed files in this pull request and generated 1 comment.

Comment thread CONTRIBUTING.md Outdated
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 5, 2026 07:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 15 changed files in this pull request and generated 2 comments.

Comment thread documentation/README.md Outdated
Comment thread documentation/README.md Outdated
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 5, 2026 07:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 14 changed files in this pull request and generated 4 comments.

Comment thread documentation/README.md Outdated
Comment thread documentation/README.md
Comment thread documentation/README.md Outdated
Comment thread README.md
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5
@Catalin-Stratulat-Ericsson

Copy link
Copy Markdown
Contributor

let me know when all the copilot reviews are handled and the PR is ready to be reviewed. ill have a look at it then @CsatariGergely

…k path

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5
Copilot AI review requested due to automatic review settings June 5, 2026 08:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 14 changed files in this pull request and generated 1 comment.

Comment thread documentation/README.md Outdated

@liamfallon liamfallon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these 5 documents should be eventually moved into issues and deleted from the repository because they are not visible to us here.

@dosubot dosubot Bot added the lgtm label Jun 10, 2026
@liamfallon

Copy link
Copy Markdown
Contributor

@CsatariGergely I guess we need to resolve all the cpilot comments before we can merge this.

@CsatariGergely

CsatariGergely commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

I think these 5 documents should be eventually moved into issues and deleted from the repository because they are not visible to us here.

I've created

and removed the documents.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5
Copilot AI review requested due to automatic review settings June 10, 2026 11:24
Issues created instead of the documents:

- Live inventory to rg kptdev#4580
- OCI support kptdev#4581
- Pipeline Merge kptdev#4582
- ARM build kptdev#4583
- kpt fn exclude kptdev#4584

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.

Comment thread documentation/README.md
Comment thread documentation/README.md Outdated
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 10, 2026 11:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.

Comment thread CONTRIBUTING.md Outdated
Comment thread documentation/content/en/faq.md
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 10, 2026
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@efiacor efiacor merged commit 6a17aef into kptdev:main Jun 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove kpt/docs

6 participants