Skip to content

Changed renderer for properties of GradedTaskGroupDto to number#1047

Open
SzBeni2003 wants to merge 1 commit into
stagingfrom
fix/task-number-renderer
Open

Changed renderer for properties of GradedTaskGroupDto to number#1047
SzBeni2003 wants to merge 1 commit into
stagingfrom
fix/task-number-renderer

Conversation

@SzBeni2003

@SzBeni2003 SzBeni2003 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved the task group overview so approval and rejection counts now display consistently as numbers with centered alignment.
    • Kept the existing labels and ordering unchanged for a familiar layout.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 69a7d660-5a68-4ce8-8d80-53f2027949dd

📥 Commits

Reviewing files that changed from the base of the PR and between f4b0b49 and 21462df.

📒 Files selected for processing (1)
  • backend/src/main/kotlin/hu/bme/sch/cmsch/component/task/GradedTaskGroupDto.kt

📝 Walkthrough

Walkthrough

The GradedTaskGroupDto's approved and rejected properties now explicitly declare renderer = OverviewType.NUMBER in their @property:GenerateOverview annotations, replacing the previous configuration that lacked an explicit renderer. Column names and order values remain unchanged.

Changes

Overview Renderer Update

Layer / File(s) Summary
Annotation renderer specification
backend/src/main/kotlin/hu/bme/sch/cmsch/component/task/GradedTaskGroupDto.kt
approved and rejected @property:GenerateOverview annotations now explicitly set renderer = OverviewType.NUMBER, keeping the same column names and order values.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • kir-dev/cmsch#1017: Also updates GradedTaskGroupDto.kt to add renderer = OverviewType.NUMBER to the same approved/rejected annotations, plus notGraded.

Suggested reviewers: Isti01

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating GradedTaskGroupDto property renderers to number.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/task-number-renderer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant