Skip to content

HsReplay as source for decks#6

Open
icetbr wants to merge 12 commits into
kimsey0:masterfrom
icetbr:master
Open

HsReplay as source for decks#6
icetbr wants to merge 12 commits into
kimsey0:masterfrom
icetbr:master

Conversation

@icetbr

@icetbr icetbr commented Jun 21, 2020

Copy link
Copy Markdown

No description provided.

@BernsteinA

Copy link
Copy Markdown

why replace metastats rather than support both metastats and hsreplay?

@icetbr

icetbr commented Jun 27, 2020

Copy link
Copy Markdown
Author

Because metastats is broken and needs fixing. I could spend hours finding the bug, which has been fixed before by the previous maintainer, or I could support hsreplay, which is much more resilient to this kind of bug.

If you know about scraping, metastats is scraped for info. From hsreplay I use something like a service specifically designed to be used for programs.

Other than that, the metastats integration used about 200 decks. I get something like 1200 decks from hsreplay.

I think it replaces metastats in that regard.

@loloman333

Copy link
Copy Markdown

Damn that should really be approved!

Is it possible to alter the URL in your HsReplaySnapshotImporter to wild and it downloads the wild decks?
Or would I have to fiddle with the Archetype detection as well?

@icetbr

icetbr commented Oct 1, 2020

Copy link
Copy Markdown
Author

Just changing the URL to GameType=RANKED_WILD should be enough. But if you look at the data at https://hsreplay.net/decks/#gameType=RANKED_WILD, there are very few decks, 4 at the time of posting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants