Skip to content

Make doctest and pre-commit workflows triggerable by dispatch#476

Merged
tmadlener merged 5 commits intomainfrom
tmadlener-patch-1
Apr 16, 2026
Merged

Make doctest and pre-commit workflows triggerable by dispatch#476
tmadlener merged 5 commits intomainfrom
tmadlener-patch-1

Conversation

@tmadlener
Copy link
Copy Markdown
Member

@tmadlener tmadlener commented Apr 16, 2026

BEGINRELEASENOTES

  • Make doctest and pre-commit workflows triggerable by dispatch

ENDRELEASENOTES

Comment thread .github/workflows/doctest.yaml Outdated
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
@tmadlener
Copy link
Copy Markdown
Member Author

Looks like the switch to default to LCG based nightlies for Alma9 breaks things since the releases are still done with spack and we just have two entirely different software stacks. I would not expect that to work, so I have switched the READMEs to also use the same nightlies that we use for building the version of k4MarlinWrapper that we want to later use for testing.

@jmcarcell
Copy link
Copy Markdown
Member

I don't understand, is this related to the visualization issue? I may have some input since I have seen something similar. But then I don't understand, we are using one stack or the other? In particular nothing changed if you don't pass the --lcg when sourcing the nightlies (only the Key4hep build action uses it).

@tmadlener
Copy link
Copy Markdown
Member Author

Ah, I think you are right. I initially thought that the doctest also fails for basic CLIC Readme, but looking at #477 it doesn't seem to be the case. So, in the end this only needs the workflow_dispatch parts, but not the change to the documentation bits.

@tmadlener tmadlener changed the title Make doctest workflow triggerable by dispatch Make doctest and pre-commit workflows triggerable by dispatch Apr 16, 2026
@tmadlener tmadlener merged commit 6590b5b into main Apr 16, 2026
5 of 7 checks passed
@tmadlener tmadlener deleted the tmadlener-patch-1 branch April 16, 2026 19:46
@tmadlener
Copy link
Copy Markdown
Member Author

The failing visualization test will be fixed with iLCSoft/CLICPerformance#146

Victor-Schwan pushed a commit to Victor-Schwan/k4MarlinWrapper that referenced this pull request Apr 17, 2026
…p#476)

* Make doctest workflow triggerable by dispatch

* Also make pre-commit have our usual triggers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants