Add Par04 style Parallel World Placements#15
Conversation
… still broken; need ILD global value but only have local
…nding code clean up
…ill need to correctly place shower in geometry. Added ODD and CLIC with fully active absorbers. Intended for use with geant4 parallel worlds once available in DD4hep.
…). Also updated Endcap model. Correct positioning of shower still to be done
…tion in Endcap pending validation
|
I suppose that given
You will also remove the geometry (and other) files that do (or should) belong here in that process? |
Yes, this branch needs a proper cleanup before it is ready. However, there are some changes to the geometry that are necessary in order to make the trick with the sensitive detector action work. Namely:
So I guess the question is @tmadlener how should we handle this? Clearly, we don't want this in the upstream k4geo. We can (and will) of course document this clearly in the ReadMe instructions for users, but we might also want these kind of fast-sim friendly geometries hosted somewhere e.g. for testing purposes etc? In general, I am also not a fan of having copies of the geometry. From discussion with Markus: we should be able to inject ‘FastSim’ sensitives for absorbers etc. via the plugin when the sensitive detectors are constructed (see: https://github.com/AIDASoft/DD4hep/blob/4dd1579cbd24b68c565fbcdaf3f7e3ef698aaad8/DDG4/plugins/Geant4DetectorSensitivesConstruction.cpp#L82) . |
I don't see a reason for this not to live in k4geo even given these constraints. There is precedent for several things in k4geo:
So while it will be somewhat hard to retrofit this into an existing geometry, I don't see a reason to not have what is essentially a copy of a geometry with slight modifications to what is and what isn't sensitive with a different version and some documentation. (This would probably also need some discussion with other people involved in k4geo, though). How to solve this on a technical level is then probably a slightly different topic, but I think that separates quite nicely from the logistics of where the compact files (and some potentially updated detector constructors) would live in the end. |
BEGINRELEASENOTES
The PR adds several new (related) features:
Note: each of these features will be factored into separate PRs and linked from here
ENDRELEASENOTES